[release/8.0] [hot reload][debugger] Resolve field types before use #93559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
thaystg,
radical and
marek-safar
as code owners
|
Tagging subscribers to this area: @thaystg Issue DetailsBackport of #93558 to release/8.0 /cc @lambdageek Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
github-actions
bot
force-pushed
the
backport/pr-93558-to-release/8.0
branch
from
895d641
to
5dcb661
Compare
lambdageek
approved these changes
Oct 16, 2023
lambdageek
added
Servicing-approved
|
Approved by tactics in email |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #93558 to release/8.0
/cc @lambdageek
Customer Impact
Customers using hot reload in mobile or WebAssembly applications may see unexpected types for newly-added fields in the debugger.
In .NET 8 we added the ability to add instance fields to existing types during a hot reload debugging session. If the field is only added (but not yet used), the debugger may show incorrect information about it. (If the field is added and used in the same "apply changes" delta, the type will be correct). This PR improves the debugger to show the correct type informtion.
Testing
New CI test
Risk
Low
Fixes #93036