Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Label support in new ILGenerator #93565

Merged
merged 13 commits into from
Oct 26, 2023
Merged

Add Label support in new ILGenerator #93565

merged 13 commits into from
Oct 26, 2023

Commits on Oct 9, 2023

  1. Add initial MaxStack calculation and tests

    @buyaa-n
    buyaa-n committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    02b9683 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Aaron Robinson <arobins@microsoft.com>
    @buyaa-n @AaronRobinsonMSFT
    buyaa-n and AaronRobinsonMSFT committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    49c69ad View commit details
    Browse the repository at this point in the history

  3. Update src/libraries/System.Reflection.Emit/src/System/Reflection/Emi… 

    …t/ILGeneratorImpl.cs

Co-authored-by: Aaron Robinson <arobins@microsoft.com>
    @buyaa-n @AaronRobinsonMSFT
    buyaa-n and AaronRobinsonMSFT committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    06be81d View commit details
    Browse the repository at this point in the history

  4. Remove space

    @buyaa-n
    buyaa-n committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    90cdba8 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Emit Label/Branching IL

    @buyaa-n
    buyaa-n committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7c1f841 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Throw when OpCode is not Switch 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @buyaa-n @jkotas
    buyaa-n and jkotas committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5461913 View commit details
    Browse the repository at this point in the history

  2. Remove extra brace

    @buyaa-n
    buyaa-n committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    3ca6b59 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Add protected factory to ILGenerator instead of making the Label cons… 

    …tructor public
    @buyaa-n
    buyaa-n committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    dc6a3ae View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Add protected factory to ILGenerator instead of making the Label cons… 

    …tructor public
    @buyaa-n
    buyaa-n committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    c46d640 View commit details
    Browse the repository at this point in the history

  2. Merge conflicts

    @buyaa-n
    buyaa-n committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f6d660e View commit details
    Browse the repository at this point in the history

  3. Mergo conflicts

    @buyaa-n
    buyaa-n committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    70c548f View commit details
    Browse the repository at this point in the history

  4. Add test for Label.Id

    @buyaa-n
    buyaa-n committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    6952b2b View commit details
    Browse the repository at this point in the history

  5. Update test to assert label.Id instead of label.GetHashCode

    @buyaa-n
    buyaa-n committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    894197b View commit details
    Browse the repository at this point in the history