Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Fix runtime tests build on CI #93646

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Conversation

radical
Copy link
Member

@radical radical commented Oct 18, 2023

Runtime tests build for wasm started timing out recently, with the job
getting cancelled, likely due to the build hitting the container limits.

This changes the inner test builds to not run in parallel at all, with
/m:1, which unblocks the CI at least.

Fixes issue: #93134

Runtime tests build for wasm started timing out recently, with the job
getting cancelled, likely due to the build hitting the container limits.

This changes the inner test builds to not run in parallel at all, with
`/m:1`, which unblocks the CI at least.

Issue: dotnet#93134
@radical radical added the arch-wasm WebAssembly architecture label Oct 18, 2023
@ghost
Copy link

ghost commented Oct 18, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Runtime tests build for wasm started timing out recently, with the job
getting cancelled, likely due to the build hitting the container limits.

This changes the inner test builds to not run in parallel at all, with
/m:1, which unblocks the CI at least.

Fixes issue: #93134

Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@ghost
Copy link

ghost commented Oct 18, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Runtime tests build for wasm started timing out recently, with the job
getting cancelled, likely due to the build hitting the container limits.

This changes the inner test builds to not run in parallel at all, with
/m:1, which unblocks the CI at least.

Fixes issue: #93134

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-coreclr

Milestone: -

@ghost
Copy link

ghost commented Oct 18, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Runtime tests build for wasm started timing out recently, with the job
getting cancelled, likely due to the build hitting the container limits.

This changes the inner test builds to not run in parallel at all, with
/m:1, which unblocks the CI at least.

Fixes issue: #93134

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono

Milestone: -

@radical
Copy link
Member Author

radical commented Oct 18, 2023

/m:2 might be fine too, and we can try that in a follow up. Trying to get to a solution soon to unblock CI!

@radical radical marked this pull request as ready for review October 18, 2023 07:54
@radical
Copy link
Member Author

radical commented Oct 18, 2023

I'm not sure why the failing test didn't get skipped. Any objections to merging this with the failed tests to unblock CI for runtime tests?

@radical
Copy link
Member Author

radical commented Oct 18, 2023

Opened #93669 for the failing tests.

@radical radical merged commit a6e3732 into dotnet:main Oct 18, 2023
98 of 101 checks passed
@radical radical deleted the runtime-tests-fix-ci branch October 18, 2023 15:03
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants