[wasm] Update Wasm.Build.Tests to build with tfm=net9.0 #93693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radical
added
NO-MERGE
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
radical
changed the title
lewing
reviewed
Oct 18, 2023
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| <TargetsCurrent Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp' and $([MSBuild]::VersionEquals('$(TargetFrameworkVersion)', '9.0'))">true</TargetsCurrent> | |||
| <!-- force net8 to use the current targets until the SDK can target net9 --> | |||
| <ForceNet8Current Condition="'$(ForceNet8Current)' == ''">true</ForceNet8Current> | |||
| <ForceNet8Current Condition="'$(ForceNet8Current)' == ''">false</ForceNet8Current> | |||
There was a problem hiding this comment.
we may just want to explicitly set this to false in wbt until sdk->installer is flowing but this is fine while you are working on this pr
There was a problem hiding this comment.
I'll revert this change, and move the setting to wbt.
This was referenced Oct 19, 2023
|
/azp run runtime-wasm-perf |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
.. targets. This is useful when `dotnet-none` is already installed and thus the installation target does not run.
.. with `tfm=net8.0` . But don't disable this for Blazor projects which are still using `tfm=net8.0`.
This allows having it enabled only for the blazor projects right now, which are still on tfm=net8.0 .
radical
removed
NO-MERGE
radical
changed the title
|
please provide some description of the changes in this PR |
pavelsavara
reviewed
Oct 26, 2023
Instead set this only for WBT.
pavelsavara
approved these changes
Oct 27, 2023
lewing
approved these changes
Oct 27, 2023
liveans
pushed a commit
to liveans/dotnet-runtime
that referenced
this pull request
Nov 9, 2023
* workload-testing.targets: Make dotnet script paths available outside .. targets. This is useful when `dotnet-none` is already installed and thus the installation target does not run. * WorkloadManifest.targets: Disable workaround to use net9.0 artifacts .. with `tfm=net8.0` . But don't disable this for Blazor projects which are still using `tfm=net8.0`. * [wasm] Improve parsing runtime pack versions from environment variables * [wasm] Allow WBTOverridePack targets use to be set per test This allows having it enabled only for the blazor projects right now, which are still on tfm=net8.0 . * [wasm] WBT: Update tests to run with net9.0 * [wasm] WBT: Remove --experiment-wasm-simd for v8 * [wasm] WBT: differentiate version used for tasks from the tfm * [wasm] Fix wasmbrowser template so it correctly updates the tfm in csproj * [wasm] WBT: Add runtime pack version for 9 in wasi * [wasm] WBT: Share nuget config files between wasm and wasi * [wasm] WBT: Fix blazor tests * [wasm] WBT: Don't test 8.0 templates yet. this will need more changes * [wasm] Don't default ForceNet8Current=false yet Instead set this only for WBT. * perf: add dummy change to trigger runtime-wasm-perf
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the test projects in Wasm.Build.Tests are built with
tfm=net8.0, since that's what the sdk supported. But to run the tests against theartifactsfrom the runtime build, the various workload packs were replaced by a couple of workarounds.tfm=net9.0. And disable the corresponding workaround in the workload by settingForceNet8Current=falsein WBT.net9.0yet. And thus the workaround to enable testing them withartifacts-ForceNet8Current=trueis unchanged.Details of changes
targets. This is useful when
dotnet-noneis already installed andthus the installation target does not run.
Fixes #91357 .