-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Disable failing runtime tests #93712
Conversation
Tagging subscribers to this area: @directhex Issue Detailsnull
|
@jkoritzinsky @trylek IIUC, excluding tests uses the paths specified in There are existing exclusions for this like runtime/src/tests/issues.targets Lines 2630 to 2632 in a40db02
.. but these do not work any more, AFAIU! Update: There might be other similar exclusions which are not effective now, and I guess not needed either? There is another instance of the above for cc @steveisok |
cc @lewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the PlatformSpecific
attribute or one of the other xunit/XunitExtensions attributes instead of issues.targets for merged tests like this.
These tests are failing as they depend on native test libraries. But wasm build for runtime tests does not support that yet. Issue: dotnet#93669
fffcf4b
to
9be3068
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably also disable these tests on the mobile platforms (all xharness platforms currently have the same infra limitations).
@steveisok @SamMonoRT do you know if these tests fail for ios, and other platforms? Look for This can be done in a follow up PR. |
Interop/PInvoke/Vector2_3_4/
tests are failing as they depend on native test libraries. Butwasm build for runtime tests does not support that yet.
Issue: #93669