Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: create recursive tail call scratch block early in morph #93764

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

AndyAyersMS
Copy link
Member

Create the scratch BB (if likely to be needed) before we get into morphing all the blocks, so that morph is not creating new blocks while morphing.

Also enhance detection of potential recursive tall calls to include cases created by GDV.

Create the scratch BB (if likely to be needed) before we get
into morphing all the blocks, so that morph is not creating
new blocks while morphing.

Also enhance detection of potential recursive tall calls to
include cases created by GDV.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 20, 2023
@ghost ghost assigned AndyAyersMS Oct 20, 2023
@ghost
Copy link

ghost commented Oct 20, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Create the scratch BB (if likely to be needed) before we get into morphing all the blocks, so that morph is not creating new blocks while morphing.

Also enhance detection of potential recursive tall calls to include cases created by GDV.

Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@AndyAyersMS AndyAyersMS added this to the 9.0.0 milestone Oct 20, 2023
@AndyAyersMS
Copy link
Member Author

cc @dotnet/jit-contrib

Likely no diffs (local run hasn't finished yet). Seems like we might be able to craft a case that exposes the prior lack of BBF_RECURSIVE_TAILCALL (which was added in #79346) for GDV cases, but I haven't tried to do so.

@AndyAyersMS
Copy link
Member Author

Timeouts for x86 on both diff and replay are a bit concerning. Retrying diffs in CI and replay locally.

@AndyAyersMS
Copy link
Member Author

Local run was fine, so assuming these timeouts are related to some CI issue.

@AndyAyersMS AndyAyersMS merged commit 2f90038 into dotnet:main Oct 20, 2023
116 of 129 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants