[main] Update dependencies from dotnet/installer #93921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…231024.2 Microsoft.Dotnet.Sdk.Internal From Version 9.0.100-alpha.1.23522.3 -> To Version 9.0.100-alpha.1.23524.2
|
@maraf New analyzer breaking the update: log |
`[] /root/helix/work/workitem/e/wbt/AppSettingsTests_haqswfqc_rzt/LazyLoadingTest.cs(15,9): Trim analysis error IL2026: LazyLoadingTest.Run(): Using member 'System.Text.Json.JsonSerializer.Serialize<TValue>(TValue, JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved. [/root/helix/work/workitem/e/wbt/AppSettingsTests_haqswfqc_rzt/WasmBasicTestApp.csproj]`
radical
approved these changes
Oct 24, 2023
liveans
pushed a commit
to liveans/dotnet-runtime
that referenced
this pull request
Nov 9, 2023
* Update dependencies from https://github.com/dotnet/installer build 20231024.2 Microsoft.Dotnet.Sdk.Internal From Version 9.0.100-alpha.1.23522.3 -> To Version 9.0.100-alpha.1.23524.2 * Suppress trim warnings `[] /root/helix/work/workitem/e/wbt/AppSettingsTests_haqswfqc_rzt/LazyLoadingTest.cs(15,9): Trim analysis error IL2026: LazyLoadingTest.Run(): Using member 'System.Text.Json.JsonSerializer.Serialize<TValue>(TValue, JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved. [/root/helix/work/workitem/e/wbt/AppSettingsTests_haqswfqc_rzt/WasmBasicTestApp.csproj]` --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Ankit Jain <radical@gmail.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/installer