Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PriorityQueue.Remove #93994

Merged
merged 10 commits into from
Oct 30, 2023
Merged

Implement PriorityQueue.Remove #93994

merged 10 commits into from
Oct 30, 2023

Conversation

eiriktsarpalis
Copy link
Member

Fix #93925.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned eiriktsarpalis Oct 25, 2023
@ghost
Copy link

ghost commented Oct 25, 2023

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #93925.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Collections, new-api-needs-documentation
Milestone: -

@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone Oct 25, 2023
tarekgh
tarekgh approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some questions and suggestions. LGTM otherwise.

@eiriktsarpalis @danmoseley
Update src/libraries/System.Collections/src/System/Collections/Generi…
851a94f 
…c/PriorityQueue.cs

Co-authored-by: Dan Moseley <danmose@microsoft.com>
@build-analysis build-analysis bot mentioned this pull request Oct 26, 2023
Open
@eiriktsarpalis eiriktsarpalis merged commit c1f4341 into dotnet:main Oct 30, 2023
109 checks passed
@eiriktsarpalis eiriktsarpalis deleted the pq-remove branch October 30, 2023 16:04
@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@danmoseley danmoseley danmoseley left review comments

@tarekgh tarekgh tarekgh approved these changes

@krwq krwq Awaiting requested review from krwq

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Collections new-api-needs-documentation
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add a Remove method to PriorityQueue
4 participants
@eiriktsarpalis @stephentoub @danmoseley @tarekgh