Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] enable timer tests #94217

Merged
merged 3 commits into from
Nov 1, 2023
Merged

[browser][MT] enable timer tests #94217

merged 3 commits into from
Nov 1, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Oct 31, 2023 •
edited
Loading

after we switched to portable timer in #94180

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Oct 31, 2023
@pavelsavara pavelsavara added this to the 9.0.0 milestone Oct 31, 2023
@pavelsavara pavelsavara self-assigned this Oct 31, 2023
@ghost
Copy link

ghost commented Oct 31, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

after we switched to portable timer

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-VM-threading-mono, os-browser
Milestone: 9.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara marked this pull request as ready for review October 31, 2023 16:22
@radical radical mentioned this pull request Oct 31, 2023
Closed
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 31, 2023
Closed
Closed
Closed
Open
Open
@pavelsavara
Copy link
Member Author

There are known CI issues listed above.
The tests enabled here passed Log

I opened new issue #94253 for

[18:04:29] info: [2023-10-31T18:04:29.045Z] [FAIL] System.Runtime.InteropServices.JavaScript.Tests.MarshalTests.MarshalFailedAsynchronousTask
[18:04:29] info: JavasScript promise did not completed.
[18:04:29] info:    at System.Runtime.InteropServices.JavaScript.Tests.MarshalTests.MarshalTask(String helperMethodName, String helperMethodArgs, String resolvedBody)
[18:04:29] info:    at System.Runtime.InteropServices.JavaScript.Tests.MarshalTests.MarshalFailedAsynchronousTask()
[18:04:29] info: --- End of stack trace from previous location ---

And

[18:04:29] info: JavasScript promise did not completed.
[18:04:29] info:    at System.Runtime.InteropServices.JavaScript.Tests.MarshalTests.MarshalTask(String helperMethodName, String helperMethodArgs, String resolvedBody)
[18:04:29] info:    at System.Runtime.InteropServices.JavaScript.Tests.MarshalTests.MarshalAsynchronousTask()
[18:04:29] info: --- End of stack trace from previous location ---

Log

@pavelsavara pavelsavara merged commit dd72781 into dotnet:main Nov 1, 2023
123 of 131 checks passed
@pavelsavara pavelsavara deleted the browser_enable_timer_tests branch November 1, 2023 06:39
@pavelsavara pavelsavara mentioned this pull request Nov 9, 2023
Closed
31 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pavelsavara @ilonatommy