Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new IMemoryCache extensions #94335

Merged
merged 7 commits into from Nov 6, 2023
Merged

feat: add new IMemoryCache extensions #94335

merged 7 commits into from Nov 6, 2023

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Nov 3, 2023

fixes #92101

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 3, 2023
@ghost
Copy link

ghost commented Nov 3, 2023

Tagging subscribers to this area: @dotnet/area-extensions-caching
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #92101

Author: WeihanLi
Assignees: -
Labels:

new-api-needs-documentation, area-Extensions-Caching
Milestone: -

WeihanLi and others added 4 commits November 4, 2023 09:20
@WeihanLi @Jozkee
Update src/libraries/Microsoft.Extensions.Caching.Abstractions/src/Me…
33fa956 
…moryCacheExtensions.cs

Co-authored-by: David Cantú <dacantu@microsoft.com>
@WeihanLi @Jozkee
Update src/libraries/Microsoft.Extensions.Caching.Abstractions/src/Me…
cae58ee 
…moryCacheExtensions.cs

Co-authored-by: David Cantú <dacantu@microsoft.com>
@WeihanLi
refactor: avoid duplicate code
c0345a2
@WeihanLi
test: update test case
a67afa5
@WeihanLi WeihanLi requested a review from Jozkee November 4, 2023 04:04
stephentoub
stephentoub approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

adamsitnik
adamsitnik approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution @WeihanLi !

@adamsitnik adamsitnik merged commit 7f7702e into dotnet:main Nov 6, 2023
109 checks passed
@adamsitnik adamsitnik added this to the 9.0.0 milestone Nov 6, 2023
@WeihanLi WeihanLi deleted the memory-cache-extension branch November 6, 2023 08:33
@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saul saul saul left review comments

@stephentoub stephentoub stephentoub approved these changes

@adamsitnik adamsitnik adamsitnik approved these changes

@Jozkee Jozkee Awaiting requested review from Jozkee

Assignees
No one assigned
Labels
area-Extensions-Caching community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
9.0.0
5 participants
@WeihanLi @saul @stephentoub @adamsitnik @Jozkee