Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] Add timeouts to AcceptConnectionAsync_ThrowingCallbackOde_KeepRunning #94398

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Nov 6, 2023

Since 26.10. this test is getting stuck on alpine-3.15-helix-arm32v7:
System.Net.Quic.Functional.Tests: [Long Running Test] 'System.Net.Quic.Tests.QuicListenerTests.AcceptConnectionAsync_ThrowingCallbackOde_KeepRunning', Elapsed: 00:02:05

Adding timeouts to it so that it doesn't affect the whole test library. Note that the console log is still full of other timeouts so we might still need to mitigate that, e.g. disable QUIC tests on arm 32.

@ghost
Copy link

ghost commented Nov 6, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Since 26.10. this test is getting stuck on alpine-3.15-helix-arm32v7:
System.Net.Quic.Functional.Tests: [Long Running Test] 'System.Net.Quic.Tests.QuicListenerTests.AcceptConnectionAsync_ThrowingCallbackOde_KeepRunning', Elapsed: 00:02:05

Adding timeouts to it so that it doesn't affect the whole test library. Note that the console log is still full of other timeouts so we might still need to mitigate that, e.g. disable QUIC tests on arm 32.

Author: ManickaP
Assignees: ManickaP
Labels:

area-System.Net.Quic

Milestone: -

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManickaP
Copy link
Member Author

ManickaP commented Nov 6, 2023

Failures unrelated.

@ManickaP ManickaP merged commit 6d76479 into dotnet:main Nov 6, 2023
107 of 109 checks passed
@ManickaP ManickaP deleted the mapichov/quic-timeout branch November 6, 2023 12:32
@ghost ghost locked as resolved and limited conversation to collaborators Dec 6, 2023
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants