Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Update dependencies from dotnet/hotreload-utils #94809

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 15, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/hotreload-utils

  • Subscription: c0fef358-3848-4a30-a438-08dbcfd61a5a
  • Build: 20231120.2
  • Date Produced: November 20, 2023 3:00:43 PM UTC
  • Commit: 5524f726f92ef862b415793758cebbd2a1950b70
  • Branch: refs/heads/release/8.0

…ild 20231115.1

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23563.1 -> To Version 8.0.0-alpha.0.23565.1
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Nov 15, 2023
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Nov 15, 2023
@carlossanlop
Copy link
Member

This codeflow is completely broken by related failures:

.packages/microsoft.dotnet.hotreload.utils.generator.buildtool/8.0.0-alpha.0.23565.1/build/Microsoft.DotNet.HotReload.Utils.Generator.BuildTool.targets(55,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/__w/1/s/.dotnet/dotnet" /__w/1/s/.packages/microsoft.dotnet.hotreload.utils.generator.buildtool/8.0.0-alpha.0.23565.1/build/../tools/net8.0/Microsoft.DotNet.HotReload.Utils.Generator.BuildTool.dll -msbuild:/__w/1/s/src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.CustomAttributeDelete/System.Reflection.Metadata.ApplyUpdate.Test.CustomAttributeDelete.csproj -script:/__w/1/s/src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.CustomAttributeDelete/deltascript.json -p:Configuration=Debug" exited with code 150.

@akoeplinger @lambdageek are you the right folks to look into this? I see you're some of the top contributors in that repo.

@akoeplinger
Copy link
Member

I can look into it but this is just an arcade bump in the repo so it doesn't need to go in today.

@lewing
Copy link
Member

lewing commented Nov 16, 2023

I can look into it but this is just an arcade bump in the repo so it doesn't need to go in today.

I think the issue is the arcade bump and implicit versions, runtime would need to take the arcade bump too and is currently blocked because of #94823 #94723

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to lower case NuGet.config repo-wide at some point, since that's the first casing it looks for on case-sensitive filesystems: https://github.com/NuGet/NuGet.Client/blob/5274994/src/NuGet.Core/NuGet.Configuration/Settings/Settings.cs#L34

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@am11 feel free to send a PR :)

dotnet-maestro bot and others added 2 commits November 20, 2023 15:30
…ild 20231120.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23523.2 -> To Version 8.0.0-alpha.0.23570.2
@akoeplinger akoeplinger merged commit 64c1856 into release/8.0-staging Nov 21, 2023
183 checks passed
@akoeplinger akoeplinger deleted the darc-release/8.0-staging-3f547e70-5a43-400c-acc4-4a82cd1da987 branch November 21, 2023 09:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants