Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0-staging] Fix JsonArray.Add and ReplaceWith regressions. #94882

Merged
merged 8 commits into from
Nov 22, 2023

Address feedback.

c64df0f
Select commit
Failed to load commit list.
Merged

[release/8.0-staging] Fix JsonArray.Add and ReplaceWith regressions. #94882

Address feedback.
c64df0f
Select commit
Failed to load commit list.
Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests) failed Nov 17, 2023 in 11m 15s

Build browser-wasm linux Release LibraryTests failed

8 errors / 0 warnings

Annotations

Check failure on line 147 in src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonNode.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build browser-wasm linux Release LibraryTests)

src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonNode.cs#L147 

src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonNode.cs(147,40): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'List<>' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 198 in src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonArray.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build browser-wasm linux Release LibraryTests)

src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonArray.cs#L198 

src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonArray.cs(198,32): error CS0115: (NETCORE_ENGINEERING_TELEMETRY=Build) 'JsonArray.GetPath(List<string>, JsonNode?)': no suitable method found to override

Check failure on line 21 in src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonArray.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build browser-wasm linux Release LibraryTests)

src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonArray.cs#L21 

src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonArray.cs(21,33): error CS0534: (NETCORE_ENGINEERING_TELEMETRY=Build) 'JsonArray' does not implement inherited abstract member 'JsonNode.GetPath(List<string>, JsonNode?)'

Check failure on line 93 in src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValue.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build browser-wasm linux Release LibraryTests)

src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValue.cs#L93 

src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValue.cs(93,32): error CS0115: (NETCORE_ENGINEERING_TELEMETRY=Build) 'JsonValue.GetPath(List<string>, JsonNode?)': no suitable method found to override

Check failure on line 12 in src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValueOfTCustomized.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build browser-wasm linux Release LibraryTests)

src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValueOfTCustomized.cs#L12 

src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValueOfTCustomized.cs(12,27): error CS0534: (NETCORE_ENGINEERING_TELEMETRY=Build) 'JsonValueCustomized<TValue>' does not implement inherited abstract member 'JsonNode.GetPath(List<string>, JsonNode?)'
View more details on Azure Pipelines