New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] Added an optional HybridGlobalization run of libraries #95324

Merged

ilonatommy merged 28 commits into dotnet:main from ilonatommy:fix-95282

Dec 12, 2023

Member

ilonatommy commented Nov 28, 2023 •

edited

Loading

Fixes #95282.

Runs on:
~~- rolling build~~ add it in a few weeks in a follow-up PR, when we decide that it is stable

on request as a part of: /azp run runtime-wasm-libtests

We have a few not supported operations, e.g. GetHashCode or Compare with certain sets of StringComparison options. Tests that use them were blocked. Some tests need further investigation, connected issues:
#95503
#95471
#95473
#95594
#95623


          Interpreted, optional lane for HG.

af7ee61

ilonatommy added arch-wasm area-Infrastructure-mono os-browser labels

ilonatommy requested review from SamMonoRT and matouskozak

November 28, 2023 12:51

ilonatommy self-assigned this

ghost commented Nov 28, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #95282.

Runs on:

rolling build
on request: /azp run runtime-wasm-hg-tests

Author:	ilonatommy
Assignees:	ilonatommy
Labels:	`arch-wasm`, `area-Infrastructure-mono`, `os-browser`
Milestone:	-

Member Author

ilonatommy commented Nov 28, 2023

/azp run runtime-wasm-hg-tests

azure-pipelines bot commented Nov 28, 2023

No pipelines are associated with this pull request.

Member Author

ilonatommy commented Nov 28, 2023

No pipelines are associated with this pull request.

@radical, am I missing something to be able to trigger the template's job?

build-analysis bot mentioned this pull request

Test_EventSource_EtwManifestGeneration* tests failing in CI #48798

Closed

Member

radical commented Nov 28, 2023

No pipelines are associated with this pull request.

@radical, am I missing something to be able to trigger the template's job?

You will need to ask FR to add a corresponding pipeline. Maybe add this to runtime-wasm-libtests?

This was referenced Nov 28, 2023

[wasm][debugger] Debugger tests getting randomly aborted on CI #89409

Open

The active test run was aborted. Reason: Test host process crashed dotnet/dnceng#451

Open


          Move hg job to runtime-wasm-libtests

a868a13

radical reviewed

View reviewed changes

eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml Show resolved Hide resolved

radical reviewed

View reviewed changes

eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml Outdated Show resolved Hide resolved

Member

radical commented Nov 29, 2023

/azp run runtime-wasm-libtests

azure-pipelines bot commented Nov 29, 2023

Azure Pipelines successfully started running 1 pipeline(s).

radical reviewed

View reviewed changes

eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml Show resolved Hide resolved


          Try fixing skipping HG.

aafba02

Member Author

ilonatommy commented Nov 29, 2023

/azp run runtime-wasm-libtests

azure-pipelines bot commented Nov 29, 2023

Azure Pipelines successfully started running 1 pipeline(s).

ilonatommy added 2 commits

November 29, 2023 10:30


          Temporarily remove, to be added in a follow up PR.

25b0229


          Added AOT version.

c77e13c

Member Author

ilonatommy commented Nov 29, 2023

/azp run runtime-wasm-libtests

azure-pipelines bot commented Nov 29, 2023

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

ilonatommy commented Nov 29, 2023

Locally, running with node v20.8.0 WasmTestOnNodeJS-System.Globalization.Hybrid.WASM.Tests passes. Is it possible that Helix uses different node versions on Windows than on Linux? Window's logs are truncated - there's no info about version there.

ilonatommy requested a review from mkhamoyan

November 29, 2023 11:51

Member Author

ilonatommy commented Dec 6, 2023

/azp run runtime-wasm-libtests

azure-pipelines bot commented Dec 6, 2023

Azure Pipelines successfully started running 1 pipeline(s).


          We shouldn't be using net8 machine anymore.

d179334

Member Author

ilonatommy commented Dec 7, 2023

/azp run runtime-wasm-libtests

azure-pipelines bot commented Dec 7, 2023

Azure Pipelines successfully started running 1 pipeline(s).


          Better logging + corrected some expected results.

110ad6f

Member Author

ilonatommy commented Dec 7, 2023

/azp run runtime-wasm-libtests

azure-pipelines bot commented Dec 7, 2023

Azure Pipelines successfully started running 1 pipeline(s).

ilonatommy added 4 commits

December 7, 2023 15:30


          Fix build

0d6f41e


          Better failure logging.

6202f5f


          Logging improvement.

8cfb79d


          Responses to bangla and bengali are different.

466a50e

Member Author

ilonatommy commented Dec 8, 2023

/azp run runtime-wasm-libtests

azure-pipelines bot commented Dec 8, 2023

Azure Pipelines successfully started running 1 pipeline(s).


          Fix for node 17.3.1.

93e09d6

Member Author

ilonatommy commented Dec 8, 2023

/azp run runtime-wasm-libtests

azure-pipelines bot commented Dec 8, 2023

Azure Pipelines successfully started running 1 pipeline(s).

ilonatommy marked this pull request as ready for review

December 11, 2023 09:16

ilonatommy requested review from lewing, pavelsavara and kg as code owners

December 11, 2023 09:16

ilonatommy requested a review from radical

December 11, 2023 09:16

radical reviewed

View reviewed changes

src/libraries/Common/tests/Tests/System/StringTests.cs Outdated Show resolved Hide resolved

radical reviewed

View reviewed changes

src/libraries/tests.proj

@@ @@ -84,6 +84,12 @@ @@
                   <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime\tests\System.Globalization.Tests\Hybrid\System.Globalization.Hybrid.WASM.Tests.csproj" />
                 </ItemGroup>
+                <!-- invariant project cannot be tested in hybrid mode; projects using functions that throw PNSE too often to block separate tests (HashCode, CompareOptions) -->

Member

radical Dec 11, 2023

projects using functions that throw PNSE too often to block separate tests (HashCode, CompareOptions)

can you explain this? And is there an issue for it?

Member Author

ilonatommy Dec 12, 2023

It's not an issue, it's by design, here is the doc

Member Author

ilonatommy Dec 12, 2023

As a follow-up job, I should add the APIs from tests that I blocked in this PR to the doc (into "Affected public APIs" sections).

radical approved these changes

View reviewed changes

Member

radical left a comment

The CI related changes LGTM 👍


          Update src/libraries/Common/tests/Tests/System/StringTests.cs

7cc6538

Co-authored-by: Ankit Jain <radical@gmail.com>

ilonatommy merged commit f2a5fbf into dotnet:main

120 of 123 checks passed

ilonatommy added a commit to ilonatommy/runtime that referenced this pull request


          Follow up for dotnet#95324

cc06c6f

ilonatommy mentioned this pull request

[doc] HybridGlobalization, add not supported APIs #95920

Merged

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

radical radical approved these changes

SamMonoRT Awaiting requested review from SamMonoRT

matouskozak Awaiting requested review from matouskozak

mkhamoyan Awaiting requested review from mkhamoyan

lewing Awaiting requested review from lewing lewing is a code owner

pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

kg Awaiting requested review from kg