Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Added SVE_GD_2A ARM64 encoding #95618

Merged
merged 6 commits into from
Dec 8, 2023
Merged

JIT: Added SVE_GD_2A ARM64 encoding #95618

merged 6 commits into from
Dec 8, 2023

Conversation

TIHan
Copy link
Member

@TIHan TIHan commented Dec 5, 2023

Contributes to #94549

This adds the SVE_GD_2A encoding.

Capstone:

A0402845  sqxtnb        z0.b, z5.h
E3442845  sqxtnt        z3.b, z7.h
00512845  sqxtunb       z0.b, z8.h
65542845  sqxtunt       z5.b, z3.h
E0482845  uqxtnb        z0.b, z7.h
204C2845  uqxtnt        z0.b, z1.h
00403045  sqxtnb        z0.h, z0.s
29453045  sqxtnt        z9.h, z9.s
C0503045  sqxtunb       z0.h, z6.s
80543045  sqxtunt       z0.h, z4.s
46483045  uqxtnb        z6.h, z2.s
204C3045  uqxtnt        z0.h, z1.s
E7406045  sqxtnb        z7.s, z7.d
00456045  sqxtnt        z0.s, z8.d
20516045  sqxtunb       z0.s, z9.d
80546045  sqxtunt       z0.s, z4.d
23496045  uqxtnb        z3.s, z9.d
604C6045  uqxtnt        z0.s, z3.d

JitDisasm:

IN00a2: 00028C                    sqxtnb  z0.b, z5.h
IN00a3: 000290                    sqxtnt  z3.b, z7.h
IN00a4: 000294                    sqxtunb z0.b, z8.h
IN00a5: 000298                    sqxtunt z5.b, z3.h
IN00a6: 00029C                    uqxtnb  z0.b, z7.h
IN00a7: 0002A0                    uqxtnt  z0.b, z1.h
IN00a8: 0002A4                    sqxtnb  z0.h, z0.s
IN00a9: 0002A8                    sqxtnt  z9.h, z9.s
IN00aa: 0002AC                    sqxtunb z0.h, z6.s
IN00ab: 0002B0                    sqxtunt z0.h, z4.s
IN00ac: 0002B4                    uqxtnb  z6.h, z2.s
IN00ad: 0002B8                    uqxtnt  z0.h, z1.s
IN00ae: 0002BC                    sqxtnb  z7.s, z7.d
IN00af: 0002C0                    sqxtnt  z0.s, z8.d
IN00b0: 0002C4                    sqxtunb z0.s, z9.d
IN00b1: 0002C8                    sqxtunt z0.s, z4.d
IN00b2: 0002CC                    uqxtnb  z3.s, z9.d
IN00b3: 0002D0                    uqxtnt  z0.s, z3.d

Edit: Pasting the screenshot of diff for easy comparison:

image

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 5, 2023
@ghost ghost assigned TIHan Dec 5, 2023
@ghost
Copy link

ghost commented Dec 5, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #94549

This adds the SVE_GD_2A encoding.

Left: capstone, Right: JitDisasm
image

Author: TIHan
Assignees: TIHan
Labels:

area-CodeGen-coreclr

Milestone: -

src/coreclr/jit/emitarm64.cpp Outdated Show resolved Hide resolved
@TIHan
Copy link
Member Author

TIHan commented Dec 5, 2023

@dotnet/jit-contrib @kunalspathak this is ready

Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/coreclr/jit/emitarm64.cpp Outdated Show resolved Hide resolved
src/coreclr/jit/emitarm64.cpp Outdated Show resolved Hide resolved
@BruceForstall BruceForstall added the arm-sve Work related to arm64 SVE/SVE2 support label Dec 7, 2023
@TIHan TIHan merged commit db333ed into dotnet:main Dec 8, 2023
129 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants