Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build tests as self-contained for native AOT #95718

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Build tests as self-contained for native AOT #95718

merged 2 commits into from
Dec 7, 2023

Conversation

MichalStrehovsky
Copy link
Member

Restores what we had here long time ago:

runtime/eng/testing/tests.singlefile.targets

Lines 34 to 35 in 8473eeb

<!-- Forced by ILLink targets; we should fix the SDK -->
<SelfContained>true</SelfContained>

runtime/src/tests/Directory.Build.targets

Lines 534 to 537 in 8473eeb

<!-- Forced by ILLink targets; we should fix the SDK -->
<SelfContained>true</SelfContained>
<HasRuntimeOutput>false</HasRuntimeOutput>
<_UsingDefaultForHasRuntimeOutput>false</_UsingDefaultForHasRuntimeOutput>

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 7, 2023
@ghost ghost assigned MichalStrehovsky Dec 7, 2023
@MichalStrehovsky MichalStrehovsky mentioned this pull request Dec 7, 2023
Merged
@jkotas jkotas mentioned this pull request Dec 7, 2023
Closed
@jakobbotsch
Copy link
Member

Can we merge to unblock?

@MichalStrehovsky
Copy link
Member Author

Can we merge to unblock?

Yup, I see enough green.

Cc @ivanpovazan @kotlarmilos I've touched an iDevice file here.

@MichalStrehovsky MichalStrehovsky merged commit ee1abba into dotnet:main Dec 7, 2023
152 of 181 checks passed
@MichalStrehovsky MichalStrehovsky deleted the fixtests branch December 7, 2023 08:10
This was referenced Dec 7, 2023
Merged
Merged
@MichalStrehovsky MichalStrehovsky mentioned this pull request Dec 7, 2023
Closed
MichalStrehovsky added a commit that referenced this pull request Dec 12, 2023
@MichalStrehovsky
Revert "Build tests as self-contained for native AOT (#95718)"
953a477 
This reverts commit ee1abba.
@MichalStrehovsky MichalStrehovsky mentioned this pull request Dec 12, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@MichalStrehovsky MichalStrehovsky

Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichalStrehovsky @jakobbotsch @jkotas