[release/8.0-staging] ServiceKey comparisons use Equals for matching #96847
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This brings RemoveAllKeyed in line with service resolution (ServiceProvider.GetRequiredKeyedService)
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection Issue DetailsBackport of #95807 to release/8.0-staging Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
@steveharter @halter73 can you please help fill out the template and send an email to Tactics requesting approval? Friendly reminder that Tuesday January 16th 4pm is the Code Complete deadline for the February Release. If all requirements are met, please merge your PR before that date and time to ensure this fix gets included in that Release. Otherwise, this will have to wait until March. |
rbhanda
added
Servicing-approved
|
@steveharter @benjaminpetit today is code complete for the March release. If this PR meets all the servicing criteria, please merge it before 4pm PT. |
| <GeneratePackageOnBuild>true</GeneratePackageOnBuild> | ||
| <ServicingVersion>1</ServicingVersion> |
There was a problem hiding this comment.
Package authoring changes LGTM.
Backport of #95807 to release/8.0-staging
/cc @steveharter @tommysor
Customer Impact
Keyed services in DI are new in 8.0, and this addresses an issue when a custom key implements
Equals(object)- in some cases theEquals()was not called when it should have been.Testing
New tests were added.
Risk
Low; simple replace from
==to.Equals()Other
<GeneratePackageOnBuild>true</GeneratePackageOnBuild><ServicingVersion>1</ServicingVersion>