Disable load/store vector APIs until Mono adds support for it #96944
Conversation
ghost
assigned 
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics Issue DetailsLoad/Store vector APIs were added in #84510 and the plan was to implement them in mono as part of #93081. However, since it is not in mono yet, when we started using it in #95513, they started throwing
Once mono implementation is complete, we should revert the changes from this PR as well as enable these tests for mono. One example is:
|
|
@tannergooding @fanyang-mono @SamMonoRT @lambdageek @dotnet/arm64-contrib @JulieLeeMSFT |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@fanyang-mono - could you please double check if the failures from |
|
Have the automatic performance tests run since this patch went in? If not, it'd be good to wait until they are so we can see the impact before merging this.
@SwapnilGaikwad's upcoming work on |
It did run - dotnet/perf-autofiling-issues#27114 |
|
None of the test failures on |
…#96944) * Revert "[libs] Skip AdvSimdEncode on Mono (dotnet#96829)" This reverts commit 1a76e37. * Revert "Use multi-reg load/store for EncodeToUtf8 (dotnet#95513)" This reverts commit fdb03ca. * Wrap load/store vector APIs in '#if false' * Disable load/store vector tests * remove the trailing space
Load/Store vector APIs were added in #84510 and the plan was to implement them in mono as part of #93081. However, since it is not in mono yet, when we started using it in #95513, they started throwing
PlatformNotSupportedException. It was not caught in #95513 because the mono CI pipeline that test theAdvSimdis only part ofllvm-aotwhich is run as part ofruntime-extra-platforms. Given that Preview1 will be out in next couple of weeks, it will be incorrect for Mono to returnAdvSimd.IsSupported == true, but throwPlatformNotSupportedExceptionfor these APIs. Working with Mono team offline, their plan is to implement them on mono side by Preview2, but until then, for Preview 1, we decided to disable them. This PR contains following changes:#if 0Once mono implementation is complete, we should revert the changes from this PR as well as enable these tests for mono. One example is:
runtime/src/tests/JIT/HardwareIntrinsics/Arm/Shared/LoadVectorx2Test.template
Line 23 in d145879