Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose AVX512F embedded rounding intrinsics. #97415

Merged
merged 28 commits into from
Feb 15, 2024
Merged

Expose AVX512F embedded rounding intrinsics. #97415

merged 28 commits into from
Feb 15, 2024

Commits on Feb 13, 2024

  1. Expose embedded rounding related scalar intrinsic APIs

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    f908fc1 View commit details
    Browse the repository at this point in the history

  2. Expose embedded rounding related arithmatic intrinsic APIs

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    6b92bd9 View commit details
    Browse the repository at this point in the history

  3. Ensure the new APIs are properly lowered

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    951752e View commit details
    Browse the repository at this point in the history

  4. Bug fixes

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    a3cba48 View commit details
    Browse the repository at this point in the history

  5. Expose embedded rounding casting APIs

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    5211cda View commit details
    Browse the repository at this point in the history

  6. Expose arithmetic embedded rounding unit tests

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    633bd55 View commit details
    Browse the repository at this point in the history

  7. Add a test template for embedded rounding APIs, this will be enough t… 

    …o cover all the binary APIs including vector and scalar operations.
    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    dc38c5a View commit details
    Browse the repository at this point in the history

  8. Add template for unary ops

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    aecb935 View commit details
    Browse the repository at this point in the history

  9. Expose all the embedded rounding unit tests generated by the templates

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    4fce5a1 View commit details
    Browse the repository at this point in the history

  10. Expose embedded rounding casting APIs unit tests

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    8338675 View commit details
    Browse the repository at this point in the history

  11. Expose handwritten unit tests for embedded rounding APIs with special… 

    … input arg lists.
    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1063c92 View commit details
    Browse the repository at this point in the history

  12. Bug fixes: 

    1. ConvertToVector256Int32/UInt32 use special code gen path, adding a fallback path when embedded rounding is activated and the control byte is not constant.
    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    c821956 View commit details
    Browse the repository at this point in the history

  13. Bug fix: 

    Fix wrong data type in the API definition.
    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    4e4b524 View commit details
    Browse the repository at this point in the history

  14. formatting

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    a39f23e View commit details
    Browse the repository at this point in the history

  15. Update API documents for embedded rounding APIs.

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    7b294dc View commit details
    Browse the repository at this point in the history

  16. resolve conflicts with dotnet#97569

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    c8f279b View commit details
    Browse the repository at this point in the history

  17. formatting

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    05a93be View commit details
    Browse the repository at this point in the history

  18. bug fix and remove un-needed SAE related intrinsics

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    3cbce2f View commit details
    Browse the repository at this point in the history

  19. resolve comments: 

    1. update the arg lists for genHWIntrinsic_R_RM
    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    0af68ea View commit details
    Browse the repository at this point in the history

  20. resolve comments: 

    Add jumptable fallback to non-table driven embedded rounding intrinsics.
    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    73bd36d View commit details
    Browse the repository at this point in the history

  21. resolve comments: 

    1. remove some redundent checks on embedded rounding intrinsics
    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    38191d3 View commit details
    Browse the repository at this point in the history

  22. Bug fix: 

    pass the correct operand GenTree node, when emitting the fallback for embedded rounding intrinsics.
    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    061a8dd View commit details
    Browse the repository at this point in the history

  23. formatting

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1367a9a View commit details
    Browse the repository at this point in the history

  24. revert an unexpected change.

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    7de90b2 View commit details
    Browse the repository at this point in the history

  25. 1.Resolve comments: 

    2. Added FMA intrinsics with embedded rounding and unit tests.
    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    d0c805c View commit details
    Browse the repository at this point in the history

  26. Expose the rest of embedded rounding APIs

    @Ruihan-Yin
    Ruihan-Yin committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    fd5a2d5 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. formatting

    @Ruihan-Yin
    Ruihan-Yin committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    aa13249 View commit details
    Browse the repository at this point in the history

  2. Ensure the control byte local is assigned to the correct register.

    @Ruihan-Yin
    Ruihan-Yin committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    7ee7749 View commit details
    Browse the repository at this point in the history