Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't copy runner to test output during regular builds" #97454

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Jan 24, 2024

Reverts #96826

@akoeplinger let me know this regressed:

it looks like
#96826
is breaking a couple things

The latter seems more problematic since we document /t:Test in a couple places and I know many people are still in the habit of using it vs dotnet test and in some cases you don't want the vstest runner

Undoing this for now. Probably we need to allow for another property to be set here, or we fix those places that broke to use the path to the runner inside the package instead (as was recommended by Xunit).

@ghost
Copy link

ghost commented Jan 24, 2024

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts #96826

@akoeplinger let me know this regressed:

it looks like
#96826
is breaking a couple things

The latter seems more problematic since we document /t:Test in a couple places and I know many people are still in the habit of using it vs dotnet test and in some cases you don't want the vstest runner

Undoing this for now. Probably we need to allow for another property to be set here, or we fix those places that broke to use the path to the runner inside the package instead (as was recommended by Xunit).

Author: ericstj
Assignees: ericstj
Labels:

area-Infrastructure-libraries

Milestone: -

@ericstj
Copy link
Member Author

ericstj commented Jan 24, 2024

Failing test was known issue and helix infrastructure issue - likely not caused by this revert. Merging this to unblock test builds.

@ViktorHofer ViktorHofer deleted the revert-96826-fix94183 branch January 24, 2024 22:30
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants