Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non locking atomic intrinsics #97527

Closed
wants to merge 6 commits into from
Closed

Use non locking atomic intrinsics #97527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
30bae52
Use non locking atomic intrinsics
MichalPetryka Jan 25, 2024
795a310
Update pal.h
MichalPetryka Jan 25, 2024
92b65fb
Move checking to CMake
MichalPetryka Jan 26, 2024
fa1d819
Update configure.cmake
MichalPetryka Jan 26, 2024
c3cf1c4
Update configure.cmake
MichalPetryka Jan 26, 2024
492ed0e
Make the code build
MichalPetryka Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/coreclr/pal/inc/pal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3639,21 +3639,33 @@ Define_InterlockMethod(
CHAR,
InterlockedExchange8(IN OUT CHAR volatile *Target, CHAR Value),
InterlockedExchange8(Target, Value),
#ifdef __clang__
__sync_swap(Target, Value);
#else
__atomic_exchange_n(Target, Value, __ATOMIC_ACQ_REL)
#endif
)

Define_InterlockMethod(
SHORT,
InterlockedExchange16(IN OUT SHORT volatile *Target, SHORT Value),
InterlockedExchange16(Target, Value),
#ifdef __clang__
__sync_swap(Target, Value);
#else
__atomic_exchange_n(Target, Value, __ATOMIC_ACQ_REL)
#endif
)

Define_InterlockMethod(
LONG,
InterlockedExchange(IN OUT LONG volatile *Target, LONG Value),
InterlockedExchange(Target, Value),
#ifdef __clang__
__sync_swap(Target, Value);
#else
__atomic_exchange_n(Target, Value, __ATOMIC_ACQ_REL)
#endif
)

#if defined(HOST_X86)
Expand All @@ -3678,12 +3690,15 @@ Define_InterlockMethod(
LONGLONG,
InterlockedExchange64(IN OUT LONGLONG volatile *Target, IN LONGLONG Value),
InterlockedExchange64(Target, Value),
#ifdef __clang__
__sync_swap(Target, Value);
#else
__atomic_exchange_n(Target, Value, __ATOMIC_ACQ_REL)
#endif
)

#endif


/*++
Function:
InterlockedCompareExchange
Expand Down
1 change: 1 addition & 0 deletions src/coreclr/pal/src/config.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@
#cmakedefine01 HAVE__SC_PHYS_PAGES
#cmakedefine01 HAVE__SC_AVPHYS_PAGES

#cmakedefine01 HAVE_LOCKFREE_ATOMICS
#cmakedefine01 REALPATH_SUPPORTS_NONEXISTENT_FILES
#cmakedefine01 SSCANF_SUPPORT_ll
#cmakedefine01 HAVE_LARGE_SNPRINTF_SUPPORT
Expand Down
17 changes: 17 additions & 0 deletions src/coreclr/pal/src/configure.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,23 @@ check_cxx_symbol_exists(_DEBUG sys/user.h USER_H_DEFINES_DEBUG)
check_cxx_symbol_exists(_SC_PHYS_PAGES unistd.h HAVE__SC_PHYS_PAGES)
check_cxx_symbol_exists(_SC_AVPHYS_PAGES unistd.h HAVE__SC_AVPHYS_PAGES)

check_c_source_compiles("
#include <stdatomic.h>

int main(void) {
#if defined(__clang__) && __has_builtin(__sync_swap) && __has_builtin(__sync_val_compare_and_swap)
return 0;
#elif ATOMIC_CHAR_LOCK_FREE == 2 && ATOMIC_SHORT_LOCK_FREE == 2 && ATOMIC_INT_LOCK_FREE == 2 && ATOMIC_LLONG_LOCK_FREE == 2
return 0;
#else
#error CoreCLR requires non-locking atomics
#endif
}" HAVE_LOCKFREE_ATOMICS)

if(NOT HAVE_LOCKFREE_ATOMICS)
message( FATAL_ERROR "CoreCLR requires non-locking atomics" )
endif(NOT HAVE_LOCKFREE_ATOMICS)

check_cxx_source_runs("
#include <sys/param.h>
#include <stdlib.h>
Expand Down