Remove fgReplaceSwitchJumpTarget; increase usage of fgReplaceJumpTarget #97664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIn preparation for improving the proliferation of edge likelihoods (as part of #93020), we should use
|
Diff results for #97664Assembly diffsAssembly diffs for osx/arm64 ran on linux/x64Diffs are based on 2,029,386 contexts (927,368 MinOpts, 1,102,018 FullOpts). MISSED contexts: 109 (0.01%) Overall (-264 bytes)
FullOpts (-264 bytes)
Details here Throughput diffsThroughput diffs for linux/arm64 ran on windows/x64Overall (-0.02% to -0.00%)
MinOpts (-0.08% to +0.00%)
FullOpts (-0.01% to -0.00%)
Throughput diffs for linux/x64 ran on windows/x64Overall (-0.03% to -0.00%)
MinOpts (-0.10% to +0.00%)
FullOpts (-0.03% to -0.00%)
Throughput diffs for osx/arm64 ran on windows/x64Overall (-0.03% to -0.00%)
MinOpts (-0.09% to +0.01%)
FullOpts (-0.01% to -0.00%)
Throughput diffs for windows/arm64 ran on windows/x64Overall (-0.01% to -0.00%)
MinOpts (-0.02% to +0.01%)
FullOpts (-0.01% to -0.00%)
Throughput diffs for windows/x64 ran on windows/x64Overall (-0.01% to -0.00%)
MinOpts (-0.03% to +0.00%)
FullOpts (-0.01% to -0.00%)
Details here |
|
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Small diffs due to changes in profile data. |
Diff results for #97664Assembly diffsAssembly diffs for linux/arm64 ran on windows/x64Diffs are based on 2,259,470 contexts (1,008,044 MinOpts, 1,251,426 FullOpts). MISSED contexts: 159 (0.01%) Overall (-624 bytes)
FullOpts (-624 bytes)
Assembly diffs for linux/x64 ran on windows/x64Diffs are based on 2,249,703 contexts (981,298 MinOpts, 1,268,405 FullOpts). MISSED contexts: 134 (0.01%) Overall (-904 bytes)
FullOpts (-904 bytes)
Assembly diffs for windows/arm64 ran on windows/x64Diffs are based on 2,070,850 contexts (937,853 MinOpts, 1,132,997 FullOpts). MISSED contexts: 139 (0.01%) Overall (-672 bytes)
FullOpts (-672 bytes)
Assembly diffs for windows/x64 ran on windows/x64Diffs are based on 2,098,526 contexts (926,221 MinOpts, 1,172,305 FullOpts). MISSED contexts: 138 (0.01%) Overall (-366 bytes)
FullOpts (-366 bytes)
Details here Assembly diffs for linux/arm ran on windows/x86Diffs are based on 2,053,507 contexts (830,101 MinOpts, 1,223,406 FullOpts). MISSED contexts: 71,368 (3.36%) Overall (+0 bytes)
FullOpts (+0 bytes)
Assembly diffs for windows/x86 ran on windows/x86Diffs are based on 2,290,755 contexts (838,165 MinOpts, 1,452,590 FullOpts). MISSED contexts: 808 (0.04%) Overall (+0 bytes)
FullOpts (+0 bytes)
Details here Throughput diffsThroughput diffs for linux/arm ran on windows/x86Overall (-0.04% to +0.00%)
MinOpts (-0.20% to +0.00%)
Throughput diffs for windows/x86 ran on windows/x86Overall (-0.03% to -0.00%)
MinOpts (-0.02% to +0.00%)
FullOpts (-0.03% to -0.00%)
Details here Throughput diffs for linux/arm64 ran on linux/x64Overall (-0.02% to -0.00%)
MinOpts (-0.08% to +0.00%)
FullOpts (-0.01% to -0.00%)
Throughput diffs for linux/x64 ran on linux/x64Overall (-0.02% to -0.00%)
MinOpts (-0.09% to 0.00%)
FullOpts (-0.02% to -0.00%)
Details here |
AndyAyersMS
approved these changes
Jan 31, 2024
I changed the parameter ordering of |
Diff results for #97664Throughput diffsThroughput diffs for linux/x64 ran on linux/x64Overall (-0.02% to -0.00%)
MinOpts (-0.09% to 0.00%)
FullOpts (-0.02% to -0.00%)
Throughput diffs for osx/arm64 ran on linux/x64Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.06% to -0.01%)
MinOpts (-0.17% to +0.00%)
FullOpts (-0.03% to -0.02%)
Throughput diffs for windows/arm64 ran on linux/x64Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.02% to -0.01%)
MinOpts (-0.03% to 0.00%)
FullOpts (-0.03% to -0.02%)
Throughput diffs for windows/x64 ran on linux/x64Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.01%)
MinOpts (-0.03% to +0.00%)
FullOpts (-0.01%)
Details here |
This was referenced Jan 31, 2024
|
Failures are known, and last change was just updating a few method signatures. |
Diff results for #97664Assembly diffsAssembly diffs for linux/arm64 ran on windows/x64Diffs are based on 2,507,317 contexts (1,007,092 MinOpts, 1,500,225 FullOpts). MISSED contexts: 1 (0.00%) Overall (-656 bytes)
FullOpts (-656 bytes)
Assembly diffs for linux/x64 ran on windows/x64Diffs are based on 2,517,908 contexts (991,070 MinOpts, 1,526,838 FullOpts). MISSED contexts: 1 (0.00%) Overall (-901 bytes)
FullOpts (-901 bytes)
Assembly diffs for osx/arm64 ran on windows/x64Diffs are based on 2,270,868 contexts (932,669 MinOpts, 1,338,199 FullOpts). MISSED contexts: 2 (0.00%) Overall (-288 bytes)
FullOpts (-288 bytes)
Assembly diffs for windows/arm64 ran on windows/x64Diffs are based on 2,341,108 contexts (938,449 MinOpts, 1,402,659 FullOpts). MISSED contexts: 9 (0.00%) Overall (-664 bytes)
FullOpts (-664 bytes)
Assembly diffs for windows/x64 ran on windows/x64Diffs are based on 2,512,209 contexts (997,391 MinOpts, 1,514,818 FullOpts). MISSED contexts: 3 (0.00%) Overall (-323 bytes)
FullOpts (-323 bytes)
Details here Assembly diffs for linux/arm ran on windows/x86Diffs are based on 2,239,390 contexts (829,328 MinOpts, 1,410,062 FullOpts). MISSED contexts: 71,274 (3.08%) Overall (+0 bytes)
FullOpts (+0 bytes)
Assembly diffs for windows/x86 ran on windows/x86Diffs are based on 2,293,451 contexts (839,658 MinOpts, 1,453,793 FullOpts). MISSED contexts: 45 (0.00%) Overall (+0 bytes)
FullOpts (+0 bytes)
Details here Throughput diffsThroughput diffs for linux/arm64 ran on linux/x64MinOpts (-0.02% to 0.00%)
FullOpts (-0.01% to -0.00%)
Details here Throughput diffs for linux/arm64 ran on windows/x64Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.02% to -0.01%)
MinOpts (-0.02% to +0.00%)
FullOpts (-0.03% to -0.01%)
Throughput diffs for linux/x64 ran on windows/x64Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.03% to -0.01%)
MinOpts (-0.10% to -0.00%)
FullOpts (-0.03% to -0.01%)
Details here Throughput diffs for linux/arm ran on windows/x86Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.03% to -0.00%)
MinOpts (-0.11% to 0.00%)
Throughput diffs for windows/x86 ran on windows/x86Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.03% to -0.00%)
MinOpts (-0.03% to +0.00%)
FullOpts (-0.03% to -0.00%)
Details here |
Diff results for #97664Assembly diffsAssembly diffs for linux/arm64 ran on windows/x64Diffs are based on 2,507,317 contexts (1,007,092 MinOpts, 1,500,225 FullOpts). MISSED contexts: 1 (0.00%) Overall (-656 bytes)
FullOpts (-656 bytes)
Assembly diffs for linux/x64 ran on windows/x64Diffs are based on 2,517,908 contexts (991,070 MinOpts, 1,526,838 FullOpts). MISSED contexts: 1 (0.00%) Overall (-901 bytes)
FullOpts (-901 bytes)
Assembly diffs for osx/arm64 ran on windows/x64Diffs are based on 2,270,868 contexts (932,669 MinOpts, 1,338,199 FullOpts). MISSED contexts: 2 (0.00%) Overall (-288 bytes)
FullOpts (-288 bytes)
Assembly diffs for windows/arm64 ran on windows/x64Diffs are based on 2,341,108 contexts (938,449 MinOpts, 1,402,659 FullOpts). MISSED contexts: 9 (0.00%) Overall (-664 bytes)
FullOpts (-664 bytes)
Assembly diffs for windows/x64 ran on windows/x64Diffs are based on 2,512,209 contexts (997,391 MinOpts, 1,514,818 FullOpts). MISSED contexts: 3 (0.00%) Overall (-323 bytes)
FullOpts (-323 bytes)
Details here Assembly diffs for linux/arm ran on windows/x86Diffs are based on 2,239,390 contexts (829,328 MinOpts, 1,410,062 FullOpts). MISSED contexts: 71,274 (3.08%) Overall (+0 bytes)
FullOpts (+0 bytes)
Assembly diffs for windows/x86 ran on windows/x86Diffs are based on 2,293,451 contexts (839,658 MinOpts, 1,453,793 FullOpts). MISSED contexts: 45 (0.00%) Overall (+0 bytes)
FullOpts (+0 bytes)
Details here Throughput diffsThroughput diffs for linux/arm64 ran on windows/x64Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.02% to -0.01%)
MinOpts (-0.02% to +0.00%)
FullOpts (-0.03% to -0.01%)
Details here Throughput diffs for linux/arm ran on windows/x86Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.03% to -0.00%)
MinOpts (-0.11% to 0.00%)
Throughput diffs for windows/x86 ran on windows/x86Warning: Different compilers used for base and diff JITs. Results may be misleading. Overall (-0.03% to -0.00%)
MinOpts (-0.03% to +0.00%)
FullOpts (-0.03% to -0.00%)
Details here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for improving the proliferation of edge likelihoods (as part of #93020), we should use
fgReplaceJumpTargetwhere possible, so that we modify predecessor edges in fewer places. I plan on updatingfgReplaceJumpTargetto always copy the likelihood of the old edge to the new edge as a follow-up to this change. Once I've done that, we can probably usefgReplaceJumpTargetin more places without losing any edge likelihoods (for example, replacefgTailMergeThrowsJumpToHelperand its variants with it).