[release/8.0-staging] Fix compilation error with generic type attributes #97717
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Strip generic type parameter attributes from partial classes emitted by the logging source generated to avoid CS0579 errors from duplicate attributes. Fixes #97498.
Update comment as suggested by code review.
Verify that attributes on generic type parameters are not lost.
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsBackport of #97613 to release/8.0-staging Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.] Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.] Testing[How was the fix verified? How was the issue missed previously? What tests were added?] Risk[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.] IMPORTANT: If this backport is for a servicing release, please verify that:
|
| @@ -5,6 +5,8 @@ | |||
| <EnableDefaultItems>true</EnableDefaultItems> | |||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | |||
| <IsPackable>true</IsPackable> | |||
| <GeneratePackageOnBuild>true</GeneratePackageOnBuild> | |||
There was a problem hiding this comment.
@ericstj @carlossanlop could you please verify this package authoring?
|
CC @artl93 |
tarekgh
added
Servicing-approved
|
This is approved offline. |
Backport of #97613 to release/8.0-staging
/cc @tarekgh @martincostello
Customer Impact
Users who employ the logging source generator and define the logger message method within a class featuring generic type parameters and applied attributes like
public partial class Greeter<[Foo] T>will encounter a compilation error. Resolving this issue is not straightforward, and workarounds may prove challenging. While this problem doesn't stem from a regression in the latest release, it poses a significant obstacle for users aiming to build for Aot, given that Aot relies on these attributes. Here is a user report in their own words #97613 (comment)Regression
Testing
Manually verified, added new tests, and passed all regression tests.
Risk
The impact is minimal; the modification specifically addresses the scenario when emitting the partial class name to prevent the compilation error. This alteration is isolated and shouldn't have any adverse effects on other aspects.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.