Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vectorize TensorPrimitives.Sin/Cos #98194

Merged
merged 5 commits into from
Feb 10, 2024
Merged

Vectorize TensorPrimitives.Sin/Cos #98194

merged 5 commits into from
Feb 10, 2024

Conversation

stephentoub
Copy link
Member

Contributes to #97193

@ghost ghost assigned stephentoub Feb 8, 2024
@ghost
Copy link

ghost commented Feb 8, 2024

Tagging subscribers to this area: @dotnet/area-system-numerics-tensors
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #97193

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Numerics.Tensors
Milestone: -

This was referenced Feb 9, 2024
Closed
Open
Closed
Closed
@stephentoub
Copy link
Member Author

The comments are all a direct copy/paste from the amd library. I'll clean them up.

@build-analysis build-analysis bot mentioned this pull request Feb 10, 2024
Closed
@stephentoub
Copy link
Member Author

Thanks. Feedback addressed. I also moved some tests to outerloop to decrease test execution time a bit.

@build-analysis build-analysis bot mentioned this pull request Feb 10, 2024
Closed
@stephentoub stephentoub merged commit b5411e3 into dotnet:main Feb 10, 2024
108 of 111 checks passed
@stephentoub stephentoub deleted the vectorizesincos branch February 10, 2024 03:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis left review comments

@tannergooding tannergooding tannergooding approved these changes

@bencyoung-Fignum bencyoung-Fignum bencyoung-Fignum left review comments

Assignees

@stephentoub stephentoub

Labels
area-System.Numerics.Tensors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stephentoub @eiriktsarpalis @tannergooding @bencyoung-Fignum