[browser][MT] Log ManagedThreadId and NativeThreadId for known test failures #98291

mkhamoyan · 2024-02-12T11:00:00Z

Log ManagedThreadId and NativeThreadId for following test failures
#98101, #98216, #97914

Once test failures will be fixed, we will remove these logs.

ghost · 2024-02-12T11:00:05Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Log ManagedThreadId and NativeThreadId for following test failures
#98101, #98216, #97914

Once test failures will be fixed, we will remove these logs.

Author:	mkhamoyan
Assignees:	mkhamoyan
Labels:	`arch-wasm`, `os-browser`
Milestone:	-

mkhamoyan · 2024-02-12T11:00:33Z

/azp run runtime-wasm

azure-pipelines · 2024-02-12T11:00:43Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2024-02-13T10:30:37Z

...eropServices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/WebWorkerTest.cs

@@ -376,6 +377,7 @@ public async Task ThreadingTimer(Executor executor)
                await tcs.Task;
            }, cts.Token);

+            Console.WriteLine("ThreadingTimer: ManagedThreadId: " + Environment.CurrentManagedThreadId + " NativeThreadId: " + WebWorkerTestHelper.NativeThreadId);


WebWorkerTest.ThreadingTimer didn't hit at all in the log. So it would be also good to print timestamp before (line 367) and after (380)

Maybe we just need to move hit = true; before tcs.SetResult(); on line 374, because that's race conditon in the test.

Updated this part accordingly.

pavelsavara · 2024-02-13T10:32:19Z

...eropServices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/WebWorkerTest.cs

@@ -451,7 +453,7 @@ public async Task WaitAssertsOnJSInteropThreads(Executor executor, NamedCall met
                {
                    exception = ex;
                }
-
+                Console.WriteLine("WaitAssertsOnJSInteropThreads: ManagedThreadId: " + Environment.CurrentManagedThreadId + " NativeThreadId: " + WebWorkerTestHelper.NativeThreadId);


would this tell us which and why Value is null ? #97914

ok, we know which exception, we don't know why.

The "why" is likely because the call is executed on different thread than we expected.

this could also be the "why"

runtime/src/libraries/System.Runtime.InteropServices.JavaScript/tests/System.Runtime.InteropServices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/WebWorkerTestBase.cs

Line 159 in 5eddce6

} catch (OperationCanceledException) { /* ignore */ }

This code is swallowing OperationCanceledException instead of passing it

Added logs to validate if that is the case.

pavelsavara · 2024-02-13T10:35:31Z

...ervices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/WebWorkerTest.Http.cs

@@ -82,6 +82,7 @@ public async Task HttpClient_CancelInDifferentThread(Executor executor1, Executo
                {
                    CancellationTokenSource cts = new CancellationTokenSource();
                    var promise = response.Content.ReadAsStringAsync(cts.Token);
+                    Console.WriteLine("HttpClient_CancelInDifferentThread: ManagedThreadId: " + Environment.CurrentManagedThreadId + " NativeThreadId: " + WebWorkerTestHelper.NativeThreadId);


use ThrowsAnyAsync<OperationCanceledException> on line 81 may hide the problem.
The question is why we have 2 different code paths.

Please log stack traces in both cases, so that we could compare them.

I kept ThrowsAsync<TaskCanceledException>, so issue will still happen but added logs to see stack traces for both TaskCanceledException and OperationCanceledException.

mkhamoyan · 2024-02-14T08:08:07Z

/azp run runtime-wasm

azure-pipelines · 2024-02-14T08:08:17Z

Azure Pipelines successfully started running 1 pipeline(s).

...ervices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/WebWorkerTest.Http.cs

pavelsavara · 2024-02-14T08:43:16Z

...Services.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/WebWorkerTestBase.cs

@@ -156,14 +156,20 @@ public class NamedCall
                    using var cts = new CancellationTokenSource(8);
                    try {
                        mr.Wait(cts.Token);
-                    } catch (OperationCanceledException) { /* ignore */ }
+                    } catch (OperationCanceledException) { 


it should not be swallowed I think. Because it's not really the expected outcome.
If it was expected outcome, the outer assert should process that case, rather than misleading null, which for this test means that something is broken for Main and WebWorker executors.

cc @radekdoulik

Updated to not swallow OperationCanceledException.

mkhamoyan · 2024-02-22T09:11:05Z

/azp run runtime-wasm

azure-pipelines · 2024-02-22T09:11:15Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2024-02-22T10:16:01Z

...Services.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/WebWorkerTestBase.cs

@@ -156,14 +156,24 @@ public class NamedCall
                    using var cts = new CancellationTokenSource(8);
                    try {
                        mr.Wait(cts.Token);
-                    } catch (OperationCanceledException) { /* ignore */ }
+                    } catch (Exception ex) {
+                        if (ex is OperationCanceledException)


Radek's solution here is bit better #98508 (comment)

Removed these changes.

pavelsavara

Please observe the outcome and let us know what we learned from it. Thank you!

Log ManagedThreadId and NativeThreadId for known test failures

a880910

mkhamoyan added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Feb 12, 2024

mkhamoyan self-assigned this Feb 12, 2024

dotnet-issue-labeler bot added the area-System.Runtime.InteropServices.JavaScript label Feb 12, 2024

mkhamoyan marked this pull request as ready for review February 12, 2024 11:00

mkhamoyan requested review from lewing and pavelsavara as code owners February 12, 2024 11:00

This was referenced Feb 12, 2024

System.Text.Json failing some large file tests #59678

Closed

[mono][tvos] OOM in System.IO.Tests.MemoryStreamTests #92467

Closed

Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049

Closed

pavelsavara reviewed Feb 13, 2024

View reviewed changes

Add more logs

879ba5b

mkhamoyan requested a review from pavelsavara February 14, 2024 08:09

pavelsavara reviewed Feb 14, 2024

View reviewed changes

Move ReadAsStringAsync inside try block

52cb799

build-analysis bot mentioned this pull request Feb 14, 2024

[browser][MT] Assert failed: Cannot find Promise for JSHandle -2 #98406

Closed

Don't swallow OperationCanceledException

039039a

mkhamoyan requested review from radekdoulik and pavelsavara February 22, 2024 09:10

pavelsavara reviewed Feb 22, 2024

View reviewed changes

Revert OperationCanceledException related changes

ff4a396

mkhamoyan requested a review from pavelsavara February 22, 2024 10:30

pavelsavara approved these changes Feb 22, 2024

View reviewed changes

mkhamoyan merged commit 8dcb639 into dotnet:main Feb 22, 2024
44 of 106 checks passed

mkhamoyan deleted the known_issue_logs branch February 22, 2024 10:57

mkhamoyan mentioned this pull request Feb 23, 2024

[mt][browser] HttpClient_CancelInDifferentThread failing with operation cancelled #98101

Open

build-analysis bot mentioned this pull request Feb 24, 2024

Error: Assert failed: Expected Promise for GCHandle #98721

Closed

github-actions bot locked and limited conversation to collaborators Mar 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[browser][MT] Log ManagedThreadId and NativeThreadId for known test failures #98291

[browser][MT] Log ManagedThreadId and NativeThreadId for known test failures #98291

mkhamoyan commented Feb 12, 2024

ghost commented Feb 12, 2024

mkhamoyan commented Feb 12, 2024

azure-pipelines bot commented Feb 12, 2024

pavelsavara Feb 13, 2024

mkhamoyan Feb 14, 2024

pavelsavara Feb 13, 2024

pavelsavara Feb 13, 2024

pavelsavara Feb 13, 2024

mkhamoyan Feb 14, 2024

pavelsavara Feb 13, 2024

mkhamoyan Feb 14, 2024

mkhamoyan commented Feb 14, 2024

azure-pipelines bot commented Feb 14, 2024

pavelsavara Feb 14, 2024

pavelsavara Feb 14, 2024

mkhamoyan Feb 22, 2024

mkhamoyan commented Feb 22, 2024

azure-pipelines bot commented Feb 22, 2024

pavelsavara Feb 22, 2024

mkhamoyan Feb 22, 2024

pavelsavara left a comment

[browser][MT] Log ManagedThreadId and NativeThreadId for known test failures #98291

[browser][MT] Log ManagedThreadId and NativeThreadId for known test failures #98291

Conversation

mkhamoyan commented Feb 12, 2024

ghost commented Feb 12, 2024

mkhamoyan commented Feb 12, 2024

azure-pipelines bot commented Feb 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkhamoyan commented Feb 14, 2024

azure-pipelines bot commented Feb 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkhamoyan commented Feb 22, 2024

azure-pipelines bot commented Feb 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pavelsavara left a comment

Choose a reason for hiding this comment