[release/9.0-preview2] Revert "Support generic arguments for calli in CoreCLR (#97079)" #99016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 15ff723.
ghost
assigned 
jkotas
changed the title
|
@carlossanlop Is there an approval process that this needs to go through? This needs to be reverted in preview2. It breaks all CsWinRT scenarios. |
|
Yes, we need Tactics approval for this. Please fill out the template, add the |
carlossanlop
approved these changes
Feb 27, 2024
carlossanlop
added
Servicing-approved
|
Approved by Tactics via email. I'll wait for the basic runtime coreclr legs to finish and then will merge it. |
AaronRobinsonMSFT
approved these changes
Feb 27, 2024
carlossanlop
merged commit 50f7525
into
dotnet:release/9.0-preview2
123 of 129 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 15ff723.
Revert of #97079 in release/9.0-preview2
/cc @AaronRobinsonMSFT
Customer Impact
Regression
Regression introduced by #97079. Breaks all CsWinRT scenarios.
Testing
New tests addressing the scenario will be added in main.
Risk
Low. Full revert of the change #97079