Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Alpine versions for release/8.0-staging #99849

Merged
merged 10 commits into from Apr 15, 2024

Conversation

richlander
Copy link
Member

@richlander richlander commented Mar 16, 2024

Related: #99837

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 16, 2024
@richlander
Copy link
Member Author

richlander commented Mar 16, 2024

Console log: 'System.Net.Quic.Functional.Tests' from job 6f054a5e-8e00-4a51-a900-fbde2ba55025 (ubuntu.2204.armarch.open) using docker image mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.17-helix-arm32v7 on a0000B4

This test is running on Alpine 3.17. That's the first Alpine to include OpenSSL 3.0. Seems like that may be an issue, although we're only seeing an issue on Arm32. Is Arm32 and OpenSSL 3.0 special for our Quic implementation?

  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
MsQuic supported and using 'libmsquic.so 2.4.0.0 (e0385b047d7bd622319e9f6c4c00184a1294eea8)'.
  Discovered:  System.Net.Quic.Functional.Tests (found 124 of 134 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on, max threads = 2)
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
./RunTests.sh: line 168:    21 Segmentation fault      (core dumped) "$RUNTIME_PATH/dotnet" exec --runtimeconfig System.Net.Quic.Functional.Tests.runtimeconfig.json --depsfile System.Net.Quic.Functional.Tests.deps.json xunit.console.dll System.Net.Quic.Functional.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing $RSP_FILE

@teo-tsirpanis teo-tsirpanis added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Mar 18, 2024
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Mar 19, 2024
@carlossanlop
Copy link
Member

@dotnet/ncl can one of you take a look at the failure and help figure out a fix for alpine?

@carlossanlop carlossanlop requested a review from a team March 19, 2024 18:40
@wfurt
Copy link
Member

wfurt commented Mar 19, 2024

this probably needs to pick up #99020
MsQuic is currently broken on ARM e.g. old versions work but new one don't

@richlander
Copy link
Member Author

How do the mechanics work for that?

@carlossanlop
Copy link
Member

How do the mechanics work for that?

We should backport that PR to the 8.0 branch. I can do it.

@wfurt
Copy link
Member

wfurt commented Mar 19, 2024

in theory you can git cherry-pick 246cda4 in your branch. Alternatively, we can backport that change first e.g. disable ARM runs before Alpine version change as they are really independent.

@carlossanlop
Copy link
Member

The backporting bot failed: #99020 (comment)

you can git cherry-pick 246cda4 in your branch

@richlander can you cherry-pick that commit into your PR please?

@richlander
Copy link
Member Author

I just looked at / tried the cherry pick. It's primarily (or all) tests. I don't have contexts on the tests to correctly resolve the conflicts. Can you do that @wfurt? Either with this PR or a separate one.

@ericstj
Copy link
Member

ericstj commented Apr 15, 2024

Build has passed, but GH badge is not updating. Merging.

@ericstj ericstj merged commit f0f42cc into dotnet:release/8.0-staging Apr 15, 2024
148 of 149 checks passed
@richlander richlander deleted the alpine-eol-8.0 branch April 15, 2024 18:23
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants