Fix x86 hardware intrinsics #99894
Merged
Fix x86 hardware intrinsics #99894
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
filipnavara
approved these changes
Mar 18, 2024
Comment on lines
-83
to
-84
| if (potentialType.Name == "X64") | ||
| potentialType = (MetadataType)potentialType.ContainingType; |
There was a problem hiding this comment.
Is this "correct"? Should we not just return "" instead to simplify things and ensure that potentialType.Name isn't returned (in this case "X64")?
There was a problem hiding this comment.
If this is the X64 nested type, we'll take the exit on line 86 and return an empty string. Nested types don't set a namespace so (potentialType.Namespace != "System.Runtime.Intrinsics.X86") is true.
jkotas
approved these changes
Mar 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetHardwareIntrinsicIdshould not handle x64 intrinsics on x86.However, we were relying on this happening in
IsHardwareIntrinsic. So also fixingIsHardwareIntrinsicto work the same as CoreCLR VM.Cc @dotnet/ilc-contrib