Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Delete some unused fields in CallArgABIInformation #99972

Merged
merged 1 commit into from
Mar 20, 2024
Merged

JIT: Delete some unused fields in CallArgABIInformation #99972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/coreclr/jit/gentree.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4435,10 +4435,6 @@ struct CallArgABIInformation
, ByteOffset(0)
, ByteSize(0)
, ByteAlignment(0)
#ifdef UNIX_AMD64_ABI
, StructIntRegs(0)
, StructFloatRegs(0)
#endif
#if defined(TARGET_LOONGARCH64) || defined(TARGET_RISCV64)
, StructFloatFieldType()
#endif
Expand Down Expand Up @@ -4474,8 +4470,6 @@ struct CallArgABIInformation
// Unix amd64 will split floating point types and integer types in structs
// between floating point and general purpose registers. Keep track of that
// information so we do not need to recompute it later.
Comment on lines 4470 to 4472
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the comment should be updated too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it since the comment equally applies to the StructDesc that we do use in a few places.

unsigned StructIntRegs;
unsigned StructFloatRegs;
SYSTEMV_AMD64_CORINFO_STRUCT_REG_PASSING_DESCRIPTOR StructDesc;
#endif // UNIX_AMD64_ABI
#if defined(TARGET_LOONGARCH64) || defined(TARGET_RISCV64)
Expand Down
2 changes: 0 additions & 2 deletions src/coreclr/jit/morph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2844,8 +2844,6 @@ void CallArgs::AddFinalArgsAndDetermineABIInfo(Compiler* comp, GenTreeCall* call
arg.AbiInfo.NumRegs = size;
arg.AbiInfo.SetByteSize(byteSize, argAlignBytes, isStructArg, isFloatHfa);
#ifdef UNIX_AMD64_ABI
arg.AbiInfo.StructIntRegs = structIntRegs;
arg.AbiInfo.StructFloatRegs = structFloatRegs;

if (isStructArg)
{
Expand Down