Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete invalid AdvSimd.ShiftRightLogicalRoundedNarrowingSaturate* overloads #99985

Merged
merged 1 commit into from Apr 18, 2024
Merged

Obsolete invalid AdvSimd.ShiftRightLogicalRoundedNarrowingSaturate* overloads #99985

merged 1 commit into from Apr 18, 2024

Conversation

jeffhandley
Copy link
Member

Fixes #95525. Per the API Review, we needed to come up with a descriptive error message that @tannergooding would confirm. I came up with:

The underlying hardware instruction does not perform a signed saturate narrowing operation, and it always returns an unsigned result. Use the unsigned overload instead.

@jeffhandley jeffhandley added area-System.Runtime.Intrinsics breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. labels Mar 19, 2024
@jeffhandley jeffhandley added this to the 9.0.0 milestone Mar 19, 2024
@jeffhandley jeffhandley self-assigned this Mar 19, 2024
@dotnet-issue-labeler dotnet-issue-labeler

This comment was marked as resolved.

Sign in to view
@dotnet-policy-service dotnet-policy-service bot added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Mar 19, 2024
@jeffhandley
Copy link
Member Author

[Breaking change]: Signed AdvSimd.ShiftRightLogicalRoundedNarrowingSaturate* methods marked as obsolete (dotnet/docs#40141)

@build-analysis build-analysis bot mentioned this pull request Mar 20, 2024
Closed
@jeffhandley jeffhandley removed needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet new-api-needs-documentation labels Mar 22, 2024
@tannergooding tannergooding merged commit 37acea2 into dotnet:main Apr 18, 2024
152 checks passed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@jeffhandley @matouskozak
Obsolete invalid AdvSimd.ShiftRightLogicalRoundedNarrowingSaturate* o…
8cbd7a1 
…verloads (dotnet#99985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannergooding tannergooding tannergooding approved these changes

Assignees

@jeffhandley jeffhandley

Labels
area-System.Runtime.Intrinsics breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Obsolete invalid overloads of AdvSimd.ShiftRightLogicalRoundedNarrowingSaturate family
2 participants
@jeffhandley @tannergooding