NativeAOT-LLVM: Do not use mmap/munmap #1510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an emscripten friendly VirtualReserve/Release implementation. Emscripten does not fully implement mmap/munmap in particular it does not zero the memory in
mmap
for theMAP_ANONYMOUS
flag. This continues from dotnet/corert#8330.When trying to merge the latest into NativeAOT-LLVM random memory crashes, usually inside the GC, have started to appear, so now seems a good time to ask for feedback on this change. This change does stop those crashes appearing so far at least.
Emscripten reports the page size as 0x4000, whereas
CommonMacros.h
hasI don't know what the implications are there, if anything maybe just performance as
posix_memalign
does not refer to the page size.