[NativeAOT-LLVM] Merge apr 24 #2543

yowl · 2024-04-06T17:05:42Z

Merges to commit 9b57a26

Of note:

Add back SetLayout to GenTreeBlk
Add new CorInfo methods, CORINFO_HELP_MEMZERO and CORINFO_HELP_NATIVE_MEMSET
Remove GT_STORE_DYN_BLK
change javascript files to come from LibrariesNativeArtifactsPath not CoreCLRNativeArtifactsPath in the nuspec

* Delete RequiresProcessIsolation on some tests - CoreMangLib/system/threading/interlocked/* - Loader/classloader/generics/* - baseservices/exceptions/* * Delete duplicated test. Loader\classloader\generics\regressions\vsw524571\staticsproblem5.cs was a duplicate of Loader\classloader\generics\Statics\Regressions\524571\StaticsProblem5.cs

…138) This adds a uniform representation that can represent the ABI information for all of our targets without needing to fall back to handling ABI specific details in all places that need to handle calling conventions. Currently nothing is using this information. I want to incrementally migrate our ABI handling to use this representation. Also, there are several potential future improvements: - Split out ABI classification per ABI instead of keeping them all within the same function - Unify `InitVarDscInfo::stackArgSize` and `InitVarDscInfo::argSize`. I am unsure why the latter is needed - Remove `LclVarDsc::GetArgReg()`, `LclVarDscInfo::GetOtherArgReg()`, HFA related members - Reuse the representation in `CallArgABIInformation` and unify the classifiers The end goal here is rewriting `genFnPrologCalleeRegArgs` to handle float and integer registers simultaneously, and to support some of the registers that the Swift calling convention is using.

* Fix HalfNumberBufferLength * Add regression test

* Update dependencies from https://github.com/dotnet/runtime build Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.3.24165.13 -> To Version 9.0.0-preview.4.24175.1 * Update dependencies from https://github.com/dotnet/sdk build Microsoft.SourceBuild.Intermediate.sdk , Microsoft.DotNet.ApiCompat.Task From Version 9.0.100-preview.3.24168.1 -> To Version 9.0.100-preview.4.24175.4 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

…(#100173) * Populate JsonPropertyInfo.AttributeProvider in the source generator. * Add test assertion checking the property type.

…calls (#100152) * Set bbCodeOffsEnd to BAD_IL_OFFSET when expanding static init calls * Re-enable NativeAOT tests that were failing

Fixes #100209

… semantics/perf (#100250)

Without this fix, it was possible for another thread to see an incorrect (zero) value of s_timeBase_numer because of a race condition.

* Provide Threading.Tasks.Dataflow package readme * Processed review comments

- Switch some `IsMultiRegReturnedType` calls to use `GenTreeCall::HasMultiRegRetVal`. - Remove `Compiler*` parameter of `TreatAsShouldHaveRetBufArg`; the function it was using on `Compiler` is static

The operation of `mkrefany` can easily be represented with more generally handled nodes within the JIT today. This also allows promotion to remain enabled for methods using this construct, so CQ improvements are expected when optimizing.

* Fix NativeName and DisplayName for browser. * Nit - revert over-renaming. * Update src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.Browser.cs Co-authored-by: Meri Khamoyan <96171496+mkhamoyan@users.noreply.github.com> * Enable more tests and fix them - initialize english and native names on CultureInfo constructio * Ubnblock fixed test. * MT does not work with HG well, revet MT to original way of working. * Expect fixed version of NativeName in tests with single treaded runtime. * Assert.Contains does not know that `\u00F1` is same as `ñ` (it does not evaluate the string before comparison) - fix it with string interpolation. * Windows has problems with comparing utf8 by xunit. --------- Co-authored-by: Meri Khamoyan <96171496+mkhamoyan@users.noreply.github.com>

…nals build (#100285) Microsoft.SourceBuild.Intermediate.source-build-externals From Version 9.0.0-alpha.1.24168.3 -> To Version 9.0.0-alpha.1.24175.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

Implements a Gauss-Seidel solver for cases where method have irreducible loops.

…vers (#99909) * Send the NegotiateSeal NTLM flag when client asked for ProtectionLevel.EncryptAndSign. Process the last handshake done message in NegotiateStream. In case of SPNEGO protocol it may contain message integrity check. Additionally, if the negotiated protocol is NTLM then we need to reset the encryption key after the message integrity check is verified. * Add test for the NegotiateSeal flag * Fix the test * Dummy commit * Fix the new _remoteOk logic in NegotiateStream to fire only when HandshakeComplete. If HandshakeComplete is not true, then the authentication blob will get processed with the normal flow. * Fix the value of NegotiateSeal in the final authentication message of Managed NTLM

Since build-in COM marshalling relies on the declaration order to build the RCW vtable, this is and has almost always resulted in an A/V or undefined behavior.

If a node has an order side effect, we can't hoist it at all: we don't know what the order dependence actually is. For example, assertion prop might have determined a node can't throw an exception, and eliminated the `GTF_EXCEPT` flag, replacing it with `GTF_ORDER_SIDEEFF`. We can't hoist because we might then hoist above the expression that led assertion prop to make that decision. This can happen in JitOptRepeat, where hoisting can follow assertion prop.

Move a check from `CallArgs::GetCustomRegister` to `hasFixedRetBuffReg`.

Returning `TYP_INT` from this function was causing `lvaInitUserArgs` to not set the "other reg" in `LclVarDsc` for SIMD types in varargs methods. This seemingly didn't usually cause issues, probably because we always DNER them and apparently `genFnPrologCalleeRegArgs` does not use `LclVarDsc::GetOtherArgReg()` in this case.

* [RISC-V] Fixes * [RISC-V] Final fixes * [RISC-V] Fixed NBitMask issue * [RISC-V] Removed some of the redundancy in the NBitMask * [RISC-V] Renamed NBitMask to WordMask and simplified it's implementation * [RISC-V] Removed noexcept from WordMask

…ubset help. (#100261)

This reverts commit 24d689c.

Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>

…o merge-apr-24

remove DotnetJs test

src/coreclr/nativeaot/Runtime/wasm/FinalizerHelpers.SingleThreaded.cpp

SingleAccretion · 2024-04-22T21:26:14Z

src/coreclr/jit/regset.h

@@ -114,6 +115,7 @@ class RegSet
        assert(rsModifiedRegsMaskInitialized);
        return (rsModifiedRegsMask & RBM_FLT_CALLEE_SAVED);
    }
+#endif // !TARGET_WASM


Suggested change

#endif // !TARGET_WASM

Suggested change

#endif // !TARGET_WASM

And add RBM_FLT_CALLEE_SAVED to targetwasm.h.

SingleAccretion · 2024-04-22T21:27:58Z

src/coreclr/jit/targetwasm.h

@@ -119,4 +119,7 @@

  #define RBM_ARG_REGS             RBM_R0
  #define RBM_FLTARG_REGS          RBM_F0
-// clang-format on
+
+  #define RBM_INT_CALLEE_SAVED     RBM_NONE;


Nit: other targets define it below STACK_ALIGN, e. g.:

https://github.com/dotnet/runtime/blob/f191f5f44ece8e8a7ea134ca6bb4fe4531f33a16/src/coreclr/jit/targetarm.h#L55-L61

src/coreclr/jit/llvmcodegen.cpp

eng/pipelines/runtimelab.yml

SingleAccretion · 2024-04-23T08:24:17Z

eng/pipelines/runtimelab.yml

+                postBuildSteps:
+                  - template: /eng/pipelines/runtimelab/runtimelab-post-build-steps.yml
+                    parameters:
+                      librariesConfiguration: Release

        - ${{ else }}:


In this else branch for the official build, I think we want to (once again) delete the Build libraries AllConfigurations for packages job and tweak the Build the whole product with Release CoreCLR one to also include our post-steps and build nativeaot.packages (basically make it look like the other ones).

...stem.Runtime.InteropServices.JavaScript/src/System.Runtime.InteropServices.JavaScript.csproj

SingleAccretion · 2024-04-23T08:45:02Z

src/mono/browser/runtime/invoke-cs.ts

@@ -15,42 +14,52 @@ import {
    get_sig, get_signature_argument_count,
    bound_cs_function_symbol, get_signature_version, alloc_stack_frame, get_signature_type,
 } from "./marshal";
+import { utf16ToString } from "./strings";


Why the import move?

…aded.cpp Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>

Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>

…stem.Runtime.InteropServices.JavaScript.csproj Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>

…o merge-apr-24

SingleAccretion · 2024-04-23T14:50:58Z

eng/pipelines/runtimelab.yml

                  # Upload the results.
                  - template: /eng/pipelines/common/upload-intermediate-artifacts-step.yml
                    parameters:
                      name: $(osGroup)$(osSubgroup)_$(archType)


Suggested change

# Upload the results.

- template: /eng/pipelines/common/upload-intermediate-artifacts-step.yml

parameters:

name: $(osGroup)$(osSubgroup)_$(archType)

runtimelab-post-build-steps.yml also does this step. I suspect doing it twice will not lead to good things.

SingleAccretion · 2024-04-23T14:53:28Z

eng/pipelines/runtimelab.yml

+                ${{ if eq(variables.isOfficialBuild, false) }}:
+                  buildArgs: -s clr.aot+libs+nativeaot.packages -c release /p:ArchiveTests=true
+                ${{ if eq(variables.isOfficialBuild, true) }}:
+                  buildArgs: -s clr.aot+libs+nativeaot.packages -c release


Hmm, I don't understand this. Shouldn't this be above, i. e. buildArgs: -s clr+libs+hosts+packs -c $(_BuildConfig) -> buildArgs: -s clr.aot+libs+nativeaot.packages -c $(_BuildConfig)?

lewing · 2024-04-23T15:25:36Z

@agocke can you help with some of the pipeline questions

SingleAccretion

Given green CI (I think that means disabling the JS test again), LGTM.

Thank you for all the work on this!

This reverts commit 53cd4b8.

yowl · 2024-04-23T16:45:05Z

Thank you for all the work on this!

Thank you for your time and help in the review.

jkotas · 2024-04-23T18:36:18Z

Thank you all!

jkotas and others added 30 commits March 25, 2024 10:29

[browser][MT] disable jiterp + enable safe points (#100156)

1fecfbc

Fix HalfNumberBufferLength (#100187)

06650b7

* Fix HalfNumberBufferLength * Add regression test

Populate JsonPropertyInfo.AttributeProvider in the source generator. …

928ffaa

…(#100173) * Populate JsonPropertyInfo.AttributeProvider in the source generator. * Add test assertion checking the property type.

JIT: Set bbCodeOffsEnd to BAD_IL_OFFSET when expanding static init …

305a52d

…calls (#100152) * Set bbCodeOffsEnd to BAD_IL_OFFSET when expanding static init calls * Re-enable NativeAOT tests that were failing

Delete ENCODE_FIELD_SIG_IndexInsteadOfToken (#100214)

903bc01

Fixes #100209

JIT: Remove remaining SVE references from emitarm64.cpp (#100100)

2c08933

Avoid IDE030X suggestions for collection expressions that would catch…

25f3883

… semantics/perf (#100250)

Switch from array to collection expression in OidLookup

dc553fe

Process.OSX: fix thread safety (#100260)

78a895f

Without this fix, it was possible for another thread to see an incorrect (zero) value of s_timeBase_numer because of a race condition.

Always zero-init if object contains pointers (#100265)

7f555e0

Provide System.Threading.Tasks.Dataflow package readme (#99664)

76c157f

* Provide Threading.Tasks.Dataflow package readme * Processed review comments

JIT: Clean up some call multi-reg ret handling (#99679)

22fcf9a

- Switch some `IsMultiRegReturnedType` calls to use `GenTreeCall::HasMultiRegRetVal`. - Remove `Compiler*` parameter of `TreatAsShouldHaveRetBufArg`; the function it was using on `Compiler` is static

JIT: Remove GT_MKREFANY (#100204)

6d91b3e

The operation of `mkrefany` can easily be represented with more generally handled nodes within the JIT today. This also allows promotion to remain enabled for methods using this construct, so CQ improvements are expected when optimizing.

[browser] Move GenerateJSModuleManifest from pack to sdk (#99675)

9038180

Delay MsQuicSendBuffers disposal to QuicStream handle closing. (#100228)

b432fc6

JIT: initial work on general count reconstruction (#99992)

ba84d1e

Implements a Gauss-Seidel solver for cases where method have irreducible loops.

remove test references to obsolete OSes (#100247)

68193c4

The layout of the ITypeLib2 interface is incorrect. (#100255)

9083a3b

Since build-in COM marshalling relies on the declaration order to build the RCW vtable, this is and has almost always resulted in an A/V or undefined behavior.

Deduplicate header Separator logic (#100179)

b42c516

JIT: Generalize hasFixedRetBuffReg for ARM64 (#100277)

e04d9aa

Move a check from `CallArgs::GetCustomRegister` to `hasFixedRetBuffReg`.

Disable new terminal logger because it eats all the output from the s…

312eb18

…ubset help. (#100261)

yowl and others added 7 commits April 22, 2024 10:53

Revert "match local version of llvm"

8ba6c2a

This reverts commit 24d689c.

disable the warnings in llvm source files generally.

eaa1ef8

Update src/coreclr/jit/llvm.cpp

d49dab8

Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>

Address some feedback

2b07e36

Merge branch 'merge-apr-24' of https://github.com/yowl/runtimelab int…

18d5fd9

…o merge-apr-24

Clean up BindJSImportST

e62bb59

Merge remote-tracking branch 'sa/Sat-FPtoUI' into merge-apr-24

5af1c97

yowl mentioned this pull request Apr 23, 2024

[NativeAOT-LLVM] Non hybrid globalization requires JS #2557

Open

reinstate saturating tests

b924ab4

remove DotnetJs test

SingleAccretion reviewed Apr 23, 2024

View reviewed changes

yowl and others added 10 commits April 23, 2024 12:50

Update src/coreclr/nativeaot/Runtime/wasm/FinalizerHelpers.SingleThre…

8e12a31

…aded.cpp Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>

Update src/coreclr/jit/llvmcodegen.cpp oops

03caca9

Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>

Update eng/pipelines/runtimelab.yml

371e46c

Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>

Update eng/pipelines/runtimelab.yml

c3bc4ee

Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>

Update eng/pipelines/runtimelab.yml

61e9367

Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>

Update eng/pipelines/runtimelab.yml

f784f3e

Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>

Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…

bf1eb7e

…stem.Runtime.InteropServices.JavaScript.csproj Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>

feedback

d612d52

Merge branch 'merge-apr-24' of https://github.com/yowl/runtimelab int…

bbe432a

…o merge-apr-24

enable test

53cd4b8

SingleAccretion reviewed Apr 23, 2024

View reviewed changes

remove old steps and duplication

f04e208

revert change

4f15f91

SingleAccretion approved these changes Apr 23, 2024

View reviewed changes

Revert "enable test"

65f5b4a

This reverts commit 53cd4b8.

jkotas merged commit 4a2148f into dotnet:feature/NativeAOT-LLVM Apr 23, 2024
12 checks passed

SingleAccretion mentioned this pull request Apr 23, 2024

[NativeAOT-LLVM] Re-enable the DotNetJsApi smoke test #2558

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NativeAOT-LLVM] Merge apr 24 #2543

[NativeAOT-LLVM] Merge apr 24 #2543

yowl commented Apr 6, 2024 •

edited

SingleAccretion Apr 22, 2024

SingleAccretion Apr 22, 2024

SingleAccretion Apr 23, 2024

SingleAccretion Apr 23, 2024

SingleAccretion Apr 23, 2024

SingleAccretion Apr 23, 2024

lewing commented Apr 23, 2024

SingleAccretion left a comment

yowl commented Apr 23, 2024

jkotas commented Apr 23, 2024

[NativeAOT-LLVM] Merge apr 24 #2543

[NativeAOT-LLVM] Merge apr 24 #2543

Conversation

yowl commented Apr 6, 2024 • edited

SingleAccretion Apr 22, 2024

Choose a reason for hiding this comment

SingleAccretion Apr 22, 2024

Choose a reason for hiding this comment

SingleAccretion Apr 23, 2024

Choose a reason for hiding this comment

SingleAccretion Apr 23, 2024

Choose a reason for hiding this comment

SingleAccretion Apr 23, 2024

Choose a reason for hiding this comment

SingleAccretion Apr 23, 2024

Choose a reason for hiding this comment

lewing commented Apr 23, 2024

SingleAccretion left a comment

Choose a reason for hiding this comment

yowl commented Apr 23, 2024

jkotas commented Apr 23, 2024

yowl commented Apr 6, 2024 •

edited