-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK with net5.0 change fails to restore dotnet repo tools #10938
Comments
do we have a repro tools project, or scenario that can repro this? |
Trying to work on a repro, we at least have a binlog if that helps: |
@wli3 I'm unsure if we really clean the %userprofile% directory for every CI run. I believe we should definitely set @Chrisboh @MattGal are we cleaning the %userprofile% (more precisely the %userprofile%.nuget) directory for every CI run or is that cached? |
I am looking for the root cause |
Adding @ChadNedzlek and @ilyas1974 |
Helix doesn't clean any folders outside of the HELIX_CORRELATION_ROOT and HELIX_WORKITEM_ROOT. It's possible that the Azure Pipelines agent would clean those directories, but it's highly unlikely, they usually work hard to redirect anything that would normally write there to some other, controlled, location. And arbitrarily deleting everything in that directory would be dangerous. |
The repro is: run tool restore with 5.0.0-preview3 Here is what happens. second restore, since preview 1 don't know what is net5.0, an extra cache line is added 3rd restore, preview 3 knows netcore5.0 == net5.0, so the select query get more than one result. And it errors out since this should not happen. This error is a special case that only happens once when we rename netcore5.0 to net5.0. And we don't have back compact requirement between previews. I suggest no product fix. Instead we should override |
True, I'd just add the scripts here always will ensure that the build workspace is either clean or new if it can't delete the older ones; builds can and should always install things like this inside the workspace if possible as this will get automatically cleaned up and not require any special knowledge of using Helix folders. |
This was previously disabled due to dotnet/sdk#10938 and its continuation issue dotnet/arcade#5402 But things might be better now?
See dotnet/runtime#33837 (comment) for more details
cc @dsplaisted @rrelyea @wli3
The text was updated successfully, but these errors were encountered: