Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet run no longer passes additional arguments to application (2.0.0-preview1-005619) #1118

Closed
mikeharder opened this issue Apr 12, 2017 · 3 comments
Assignees
Milestone

Comments

@mikeharder
Copy link
Contributor

mikeharder commented Apr 12, 2017

Repro Steps

  1. Install .NET SDK 2.0.0-preview1-005619
  2. dotnet new console
  3. Edit Program.cs and add Console.WriteLine(args.Length)
  4. dotnet restore
  5. dotnet run -- foo
Expected: 1
Actual: 0

Looking at the process tree, I can see that dotnet run is not passing the arguments to dotnet exec.

Doesn't repro on previous build 2.0.0-preview1-005488.

@mikeharder mikeharder changed the title dotnet run no longer passes additional arguments to application dotnet run no longer passes additional arguments to application (2.0.0-preview1-005619) Apr 12, 2017
@eerhardt
Copy link
Member

Doing a quick investigation, it looks like a regression with using the separator --. I ran dotnet run foo and 1 was outputted. I assume this regression came from using the new https://github.com/dotnet/CliCommandLineParser/ parser in the cli.

/cc @jonsequitur

mikeharder added a commit to aspnet/ServerTests that referenced this issue Apr 12, 2017
- Workaround for regression in `dotnet run` (dotnet/sdk#1118)
mikeharder added a commit to aspnet/ServerTests that referenced this issue Apr 12, 2017
- Workaround for regression in `dotnet run` (dotnet/sdk#1118)
mikeharder added a commit to aspnet/Hosting that referenced this issue Apr 12, 2017
- Workaround for "dotnet run no longer passes additional arguments to application" (dotnet/sdk#1118)
mikeharder added a commit to aspnet/Hosting that referenced this issue Apr 12, 2017
- Workaround for "dotnet run no longer passes additional arguments to application" (dotnet/sdk#1118)
@wli3
Copy link

wli3 commented Apr 12, 2017

(working on it)

@wli3
Copy link

wli3 commented Apr 13, 2017

[update] This branch should be able to fix the parser issue. 'foo' is in args now. However, the other functional test still cannot pass.

https://github.com/dotnet/cli/compare/master...wli3:fix-dotnetrun--foo?expand=1

I am not sure if my set up is wrong in the beginning. "MSBuildTestApp" app can take whatever args and still print hello world?

@livarcocc livarcocc added this to the 2.0 milestone Apr 14, 2017
mmitche pushed a commit to mmitche/sdk that referenced this issue Jun 5, 2020
…120.6 (dotnet#1118)

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19570.6
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jun 7, 2022
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants