Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding diagnostic messages when trimming winforms and wpf apps #16892

Merged
merged 11 commits into from
Apr 17, 2021
Merged

Adding diagnostic messages when trimming winforms and wpf apps #16892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
34fd40b
Adding diagnostic messages when trimming winforms/wpf
LakshanF Apr 13, 2021
91a696a
Incorporating FB
LakshanF Apr 14, 2021
3ca92da
Incorporate FB to follow standard practice for this type of feature s…
LakshanF Apr 14, 2021
61c84c6
incorporate FB
LakshanF Apr 15, 2021
d1798ec
missed the wpf wanring wording change
LakshanF Apr 15, 2021
816a748
better link and changed property casing
LakshanF Apr 15, 2021
c99da83
Fixes after discussion on the plan
LakshanF Apr 16, 2021
df83ec3
Merge branch 'main' into winformswrn
LakshanF Apr 16, 2021
39314c5
fix a test failure
LakshanF Apr 16, 2021
2c0d1e3
Merge branch 'winformswrn' of https://github.com/LakshanF/sdk into wi…
LakshanF Apr 16, 2021
fb93d14
fix a test typo
LakshanF Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Tasks/Common/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,4 +766,12 @@ The following are names of parameters or literal values and should not be transl
<value>NETSDK1164: Compression in a single file bundle is only supported when publishing a self-contained application.</value>
<comment>{StrBegin="NETSDK1142: "}</comment>
</data>
</root>
<data name="TrimmingWindowsFormsIsNotSupported" xml:space="preserve">
<value>NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</value>
<comment>{StrBegin="NETSDK1164: "}</comment>
</data>
<data name="TrimmingWpfIsNotSupported" xml:space="preserve">
<value>NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'm pretty sure that WPF is capitalized... since it's an abbreviation.

<comment>{StrBegin="NETSDK1165: "}</comment>
</data>
</root>
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,16 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1127: Targeting Pack {0} není nainstalovaný. Obnovte ho prosím a zkuste to znovu.</target>
<note>{StrBegin="NETSDK1127: "}</note>
</trans-unit>
<trans-unit id="TrimmingWindowsFormsIsNotSupported">
<source>NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</source>
<target state="new">NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</target>
<note>{StrBegin="NETSDK1164: "}</note>
</trans-unit>
<trans-unit id="TrimmingWpfIsNotSupported">
<source>NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</source>
<target state="new">NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</target>
<note>{StrBegin="NETSDK1165: "}</note>
</trans-unit>
<trans-unit id="UnableToFindResolvedPath">
<source>NETSDK1016: Unable to find resolved path for '{0}'.</source>
<target state="translated">NETSDK1016: Nepodařilo se najít vyhodnocenou cestu pro {0}.</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,16 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1127: Das Paket zur Festlegung von Zielversionen "{0}" ist nicht installiert. Führen Sie eine Wiederherstellung durch, und versuchen Sie es noch mal.</target>
<note>{StrBegin="NETSDK1127: "}</note>
</trans-unit>
<trans-unit id="TrimmingWindowsFormsIsNotSupported">
<source>NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</source>
<target state="new">NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</target>
<note>{StrBegin="NETSDK1164: "}</note>
</trans-unit>
<trans-unit id="TrimmingWpfIsNotSupported">
<source>NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</source>
<target state="new">NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</target>
<note>{StrBegin="NETSDK1165: "}</note>
</trans-unit>
<trans-unit id="UnableToFindResolvedPath">
<source>NETSDK1016: Unable to find resolved path for '{0}'.</source>
<target state="translated">NETSDK1016: Der aufgelöste Pfad für "{0}" wurde nicht gefunden.</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,16 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1127: El paquete de compatibilidad {0} no está instalado. Restáurelo y vuelva a intentarlo.</target>
<note>{StrBegin="NETSDK1127: "}</note>
</trans-unit>
<trans-unit id="TrimmingWindowsFormsIsNotSupported">
<source>NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</source>
<target state="new">NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</target>
<note>{StrBegin="NETSDK1164: "}</note>
</trans-unit>
<trans-unit id="TrimmingWpfIsNotSupported">
<source>NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</source>
<target state="new">NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</target>
<note>{StrBegin="NETSDK1165: "}</note>
</trans-unit>
<trans-unit id="UnableToFindResolvedPath">
<source>NETSDK1016: Unable to find resolved path for '{0}'.</source>
<target state="translated">NETSDK1016: No se encuentra la ruta de acceso resuelta para "{0}".</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,16 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1127: le pack de ciblage {0} n'est pas installé. Effectuez une restauration, puis réessayez.</target>
<note>{StrBegin="NETSDK1127: "}</note>
</trans-unit>
<trans-unit id="TrimmingWindowsFormsIsNotSupported">
<source>NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</source>
<target state="new">NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</target>
<note>{StrBegin="NETSDK1164: "}</note>
</trans-unit>
<trans-unit id="TrimmingWpfIsNotSupported">
<source>NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</source>
<target state="new">NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</target>
<note>{StrBegin="NETSDK1165: "}</note>
</trans-unit>
<trans-unit id="UnableToFindResolvedPath">
<source>NETSDK1016: Unable to find resolved path for '{0}'.</source>
<target state="translated">NETSDK1016: Chemin résolu introuvable pour '{0}'.</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,16 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1127: il Targeting Pack {0} non è installato. Ripristinare e riprovare.</target>
<note>{StrBegin="NETSDK1127: "}</note>
</trans-unit>
<trans-unit id="TrimmingWindowsFormsIsNotSupported">
<source>NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</source>
<target state="new">NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</target>
<note>{StrBegin="NETSDK1164: "}</note>
</trans-unit>
<trans-unit id="TrimmingWpfIsNotSupported">
<source>NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</source>
<target state="new">NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</target>
<note>{StrBegin="NETSDK1165: "}</note>
</trans-unit>
<trans-unit id="UnableToFindResolvedPath">
<source>NETSDK1016: Unable to find resolved path for '{0}'.</source>
<target state="translated">NETSDK1016: il percorso risolto per '{0}' non è stato trovato.</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,16 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1127: ターゲット パック {0} がインストールされていません。復元して、もう一度お試しください。</target>
<note>{StrBegin="NETSDK1127: "}</note>
</trans-unit>
<trans-unit id="TrimmingWindowsFormsIsNotSupported">
<source>NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</source>
<target state="new">NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</target>
<note>{StrBegin="NETSDK1164: "}</note>
</trans-unit>
<trans-unit id="TrimmingWpfIsNotSupported">
<source>NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</source>
<target state="new">NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</target>
<note>{StrBegin="NETSDK1165: "}</note>
</trans-unit>
<trans-unit id="UnableToFindResolvedPath">
<source>NETSDK1016: Unable to find resolved path for '{0}'.</source>
<target state="translated">NETSDK1016: 解決された '{0}' のパスが見つかりません。</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,16 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1127: 타기팅 팩 {0}이(가) 설치되어 있지 않습니다. 복원한 후 다시 시도하세요.</target>
<note>{StrBegin="NETSDK1127: "}</note>
</trans-unit>
<trans-unit id="TrimmingWindowsFormsIsNotSupported">
<source>NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</source>
<target state="new">NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</target>
<note>{StrBegin="NETSDK1164: "}</note>
</trans-unit>
<trans-unit id="TrimmingWpfIsNotSupported">
<source>NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</source>
<target state="new">NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</target>
<note>{StrBegin="NETSDK1165: "}</note>
</trans-unit>
<trans-unit id="UnableToFindResolvedPath">
<source>NETSDK1016: Unable to find resolved path for '{0}'.</source>
<target state="translated">NETSDK1016: '{0}'에 대해 확인된 경로를 찾을 수 없습니다.</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,16 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1127: Pakiet docelowy {0} nie jest zainstalowany. Wykonaj przywrócenie i spróbuj ponownie.</target>
<note>{StrBegin="NETSDK1127: "}</note>
</trans-unit>
<trans-unit id="TrimmingWindowsFormsIsNotSupported">
<source>NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</source>
<target state="new">NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</target>
<note>{StrBegin="NETSDK1164: "}</note>
</trans-unit>
<trans-unit id="TrimmingWpfIsNotSupported">
<source>NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</source>
<target state="new">NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</target>
<note>{StrBegin="NETSDK1165: "}</note>
</trans-unit>
<trans-unit id="UnableToFindResolvedPath">
<source>NETSDK1016: Unable to find resolved path for '{0}'.</source>
<target state="translated">NETSDK1016: Nie można odnaleźć rozpoznanej ścieżki dla elementu „{0}”.</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,16 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1127: o pacote de direcionamento do {0} não está instalado. Restaure e tente novamente.</target>
<note>{StrBegin="NETSDK1127: "}</note>
</trans-unit>
<trans-unit id="TrimmingWindowsFormsIsNotSupported">
<source>NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</source>
<target state="new">NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</target>
<note>{StrBegin="NETSDK1164: "}</note>
</trans-unit>
<trans-unit id="TrimmingWpfIsNotSupported">
<source>NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</source>
<target state="new">NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</target>
<note>{StrBegin="NETSDK1165: "}</note>
</trans-unit>
<trans-unit id="UnableToFindResolvedPath">
<source>NETSDK1016: Unable to find resolved path for '{0}'.</source>
<target state="translated">NETSDK1016: Não foi possível localizar o caminho resolvido para '{0}'.</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,16 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1127: пакет нацеливания {0} не установлен. Выполните восстановление и повторите попытку.</target>
<note>{StrBegin="NETSDK1127: "}</note>
</trans-unit>
<trans-unit id="TrimmingWindowsFormsIsNotSupported">
<source>NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</source>
<target state="new">NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</target>
<note>{StrBegin="NETSDK1164: "}</note>
</trans-unit>
<trans-unit id="TrimmingWpfIsNotSupported">
<source>NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</source>
<target state="new">NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</target>
<note>{StrBegin="NETSDK1165: "}</note>
</trans-unit>
<trans-unit id="UnableToFindResolvedPath">
<source>NETSDK1016: Unable to find resolved path for '{0}'.</source>
<target state="translated">NETSDK1016: не удается найти разрешенный путь для "{0}".</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,16 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1127: {0} hedefleme paketi yüklü değil. Lütfen geri yükleyip yeniden deneyin.</target>
<note>{StrBegin="NETSDK1127: "}</note>
</trans-unit>
<trans-unit id="TrimmingWindowsFormsIsNotSupported">
<source>NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</source>
<target state="new">NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</target>
<note>{StrBegin="NETSDK1164: "}</note>
</trans-unit>
<trans-unit id="TrimmingWpfIsNotSupported">
<source>NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</source>
<target state="new">NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</target>
<note>{StrBegin="NETSDK1165: "}</note>
</trans-unit>
<trans-unit id="UnableToFindResolvedPath">
<source>NETSDK1016: Unable to find resolved path for '{0}'.</source>
<target state="translated">NETSDK1016: '{0}' için çözümlenmiş yol bulunamıyor.</target>
Expand Down
10 changes: 10 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,16 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1127: 未安装目标包 {0}。请还原并重试。</target>
<note>{StrBegin="NETSDK1127: "}</note>
</trans-unit>
<trans-unit id="TrimmingWindowsFormsIsNotSupported">
<source>NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</source>
<target state="new">NETSDK1164: Windows Forms is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/windows-forms for more details.</target>
<note>{StrBegin="NETSDK1164: "}</note>
</trans-unit>
<trans-unit id="TrimmingWpfIsNotSupported">
<source>NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</source>
<target state="new">NETSDK1165: Wpf is not supported or recommended with trimming enabled. Please go to https://aka.ms/dotnet-illink/wpf for more details.</target>
<note>{StrBegin="NETSDK1165: "}</note>
</trans-unit>
<trans-unit id="UnableToFindResolvedPath">
<source>NETSDK1016: Unable to find resolved path for '{0}'.</source>
<target state="translated">NETSDK1016: 无法找到“{0}”的已解析路径。</target>
Expand Down
Loading