Don't infer UseMonoRuntime based on the RID #16909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is problematic when the RID is set in the .csproj, or when using RuntimeIdentifier_s_. We will require workloads to explicitly opt-in to the Mono runtime packs.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
dsplaisted
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
@Redth @jonathanpeppers The ios and android workloads may need to set UseMonoRuntime in response to this.
|
Yup I've talked to @pjcollins about it and the changes are in progress in XA/XI. |
|
I think we already have it in, so hopefully will work when we get the newer dotnet/sdk: |
akoeplinger
added a commit
to dotnet/runtime
that referenced
this pull request
Jun 10, 2021
…me packs This is necessary after the changes from dotnet/sdk#16909.
ViktorHofer
added a commit
to dotnet/runtime
that referenced
this pull request
Jun 11, 2021
* Update dotnet SDK to 6.0 Preview 4 Update the minimum and target version of the SDK to 6.0 Preview 4. Part of #53411 * Switch to using eng/targetingpacks.targets for redirecting runtime pack location in src/mono/sample * Fix binder tracing tests * Set UseMonoRuntime property so the dotnet SDK can pull the mono runtime packs This is necessary after the changes from dotnet/sdk#16909. * Move UseMonoRuntimeProperty and set it to false in coreclr Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Elinor Fung <elfung@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is problematic when the RID is set in the .csproj, or when using RuntimeIdentifier_s_.
We will require workloads to explicitly opt-in to the Mono runtime packs.