-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Set UseMonoRuntime property so the dotnet SDK can pull the mono runti…
…me packs This is necessary after the changes from dotnet/sdk#16909.
- Loading branch information
1 parent
77da330
commit f2ddc6d
Showing
6 changed files
with
17 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,5 +21,8 @@ | |
|
||
<ItemGroup> | ||
<FrameworkReference Include="Microsoft.NETCore.App" /> | ||
<FrameworkReference Update="Microsoft.NETCore.App" | ||
RuntimePackLabels="Mono" | ||
Condition="'$(UseMonoRuntime)' == 'true'" /> | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
akoeplinger
Author
Member
|
||
</ItemGroup> | ||
</Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ | |
<RepositoryEngineeringDir>{RepositoryEngineeringDir}</RepositoryEngineeringDir> | ||
<TargetFramework>{NetCoreAppCurrent}</TargetFramework> | ||
<RuntimeIdentifier>{RuntimeIdentifier}</RuntimeIdentifier> | ||
<UseMonoRuntime>{UseMonoRuntime}</UseMonoRuntime> | ||
This comment has been minimized.
Sorry, something went wrong.
ViktorHofer
Member
|
||
<TargetingPackDir>{TargetingPackDir}</TargetingPackDir> | ||
<NETCoreAppMaximumVersion>{NetCoreAppMaximumVersion}</NETCoreAppMaximumVersion> | ||
<MicrosoftNETCoreAppVersion>{MicrosoftNETCoreAppVersion}</MicrosoftNETCoreAppVersion> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why is that necessary? Doesn't the SDK add that FrameworkReference?