-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opt into IEventSource4 #23834
Opt into IEventSource4 #23834
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but shouldn't this flow to main via normal codeflow anyway?
There are two loggers here. While working on #23249 I discovered that this one didn't need to change, but that is surprising and when @KirillOsenkov asked about it offline I started wondering whether it was because of dotnet/msbuild#7219. It's at worst harmless to opt both in, so I support this change. However, I think the right place for it might be |
Could one of you please retarget to the right branch? |
@KirillOsenkov I've done so, but now it's bringing a whole bunch of commits from main. You'll need to rebase locally and force push I think. |
5e89c04
to
32f4dbc
Compare
Done, thanks |
This is similar to #23249