Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt into IEventSource4 #23834

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Conversation

KirillOsenkov
Copy link
Member

@KirillOsenkov KirillOsenkov commented Feb 9, 2022

This is similar to #23249

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but shouldn't this flow to main via normal codeflow anyway?

@rainersigwald
Copy link
Member

There are two loggers here. While working on #23249 I discovered that this one didn't need to change, but that is surprising and when @KirillOsenkov asked about it offline I started wondering whether it was because of dotnet/msbuild#7219. It's at worst harmless to opt both in, so I support this change. However, I think the right place for it might be release/6.0.3xx so it ships sooner than .NET 7.

@KirillOsenkov
Copy link
Member Author

Could one of you please retarget to the right branch?

@dsplaisted dsplaisted changed the base branch from main to release/6.0.3xx February 9, 2022 17:38
@dsplaisted
Copy link
Member

Could one of you please retarget to the right branch?

@KirillOsenkov I've done so, but now it's bringing a whole bunch of commits from main. You'll need to rebase locally and force push I think.

@KirillOsenkov
Copy link
Member Author

Done, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants