[main] Update dependencies from dotnet/command-line-api #29131

dotnet-maestro · 2022-11-18T22:09:45Z

This pull request updates the following dependencies

From https://github.com/dotnet/command-line-api

Subscription: a08a5052-c9e7-44a2-9fba-08d94728d7f2
Build: 20230607.1
Date Produced: June 8, 2023 12:03:47 AM UTC
Commit: 02fe27cd6a9b001c8feb7938e6ef4b3799745759
Branch: refs/heads/main

Updates:
- Microsoft.SourceBuild.Intermediate.command-line-api: from 0.1.356401 to 0.1.430701
- System.CommandLine: from 2.0.0-beta4.22564.1 to 2.0.0-beta4.23307.1

…uild 20221114.2 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.356401 -> To Version 0.1.356402

…uild 20221118.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.356401 -> To Version 0.1.356801

marek-safar · 2022-11-21T14:58:38Z

@adamsitnik could you help with updating CLI too?

adamsitnik

We are currently introducing a lot of small breaking changes to System.CommandLine and I would prefer to merge the updates in larger batches, otherwise we have to update both SDK and runtime few times a week.

I've assigned the PR to myself and applied NO MERGE label. In a week/two I am going to solve all the issues and merge it.

marcpopMSFT · 2022-12-06T21:02:16Z

@adamsitnik how are the breaking changes coming along? This is our oldest outstanding codeflow PR so popped up on my radar.

…uild 20221213.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.356401 -> To Version 0.1.361301

ViktorHofer · 2023-01-17T17:22:14Z

@adamsitnik @jeffhandley as we are fast approaching Preview 1 code-complete, can we please work on resolving the breaking changes and get this in?

adamsitnik · 2023-01-18T19:45:26Z

@ViktorHofer we are still not done with introducing breaking changes to S.CL. There were no bug fixes/new features merged in the meantime and there are multiple other repos depending on S.CL which could get easily broken after updating the version used by SDK. So I would prefer to defer this to Preview 2.

jeffhandley · 2023-01-19T05:34:34Z

@ViktorHofer / @dotnet/area-infrastructure-libraries - is there something we should do to turn this flow off until @adamsitnik gives us the all-clear? Or is it better practice to keep this PR open for another month?

ViktorHofer · 2023-01-19T07:15:35Z

@MichaelSimons @mmitche is it possible to even build the product without taking this dependency update? Wouldn't we be in an incoherent state? I bet this would at least block source build, right?

MichaelSimons · 2023-01-19T14:36:45Z

@MichaelSimons @mmitche is it possible to even build the product without taking this dependency update? Wouldn't we be in an incoherent state? I bet this would at least block source build, right?

Have these breaking changes flowed into any other repos yet? @ViktorHofer is right in that the build has to be coherent in regards to the version of S.CL referenced. Everyone has to be on the same version. This is runtime, sdk, format, templating, and sourcelink. Did I miss any?

…uild 20230119.2 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.356401 -> To Version 0.1.406902

* OptionResult.Tokens returns Tokens of all its children * only CommandResult defines Children property * don't search for ParseError more than once

…y for Option<T>, to avoid type mismatches (example: Option<int> using default value as "abc")

# Conflicts: # src/Cli/Microsoft.TemplateEngine.Cli/CliTemplateParameter.cs # src/Cli/dotnet/commands/dotnet-list/dotnet-list-package/ListPackageReferencesCommandParser.cs # src/Cli/dotnet/commands/dotnet-test/TestCommandParser.cs

adamsitnik · 2023-01-20T12:14:01Z

src/Cli/Microsoft.TemplateEngine.Cli/CliTemplateParameter.cs

@@ -150,7 +151,14 @@ internal Option GetOption(IReadOnlySet<string> aliases)
                if (!string.IsNullOrWhiteSpace(DefaultValue)
                    || (Type == ParameterType.String || Type == ParameterType.Choice) && DefaultValue != null)
                {
-                    option.SetDefaultValue(DefaultValue);
+                    if (option is Option<string> stringOption)


SetDefaultValue is now avilable only for Option<T> (not the non-generic Option), to avoid type mismatches (example: Option<int> using default value "abc").

I was not 100% sure that it's never something else than Option<string> here, so I've added the Debug.Fail to throw during development and not throw in the release builds.

adamsitnik · 2023-01-20T12:15:33Z

src/Cli/Microsoft.TemplateEngine.Cli/Commands/Extensions.cs

@@ -25,24 +26,15 @@ internal static class Extensions
        /// <summary>
        /// Checks if <paramref name="parseResult"/> contains an error for <paramref name="option"/>.
        /// </summary>
-        internal static bool HasErrorFor(this ParseResult parseResult, Option option)
+        internal static bool HasErrorFor(this ParseResult parseResult, Option option, [NotNullWhen(true)] out ParseError? error)


this is also a perf optimization: previously we were iterating the errors up to three times, now it's only once and the caller does not need to search for the error again

adamsitnik · 2023-01-20T12:17:25Z

src/Cli/Microsoft.TemplateEngine.Cli/Commands/NewCommand.Legacy.cs

@@ -79,7 +79,12 @@ internal void ValidateArgumentsAreNotUsed(CommandResult commandResult)

        internal void ValidateOptionUsage(CommandResult commandResult, Option option)
        {
-            OptionResult? optionResult = commandResult.Parent?.Children.FirstOrDefault(symbol => symbol.Symbol == option) as OptionResult;
+            if (commandResult.Parent is not CommandResult parentResult)


A parent of CommandResult can be only another CommandResult. In case it's null it means it's RootCommand.

adamsitnik · 2023-01-20T12:18:09Z

src/Cli/Microsoft.TemplateEngine.Cli/Commands/create/InvalidTemplateOptionResult.cs

@@ -83,13 +83,8 @@ public bool Equals(InvalidTemplateOptionResult? other)
            return this.Equals(other as object);
        }

-        internal static new InvalidTemplateOptionResult FromParseResult(TemplateOption option, ParseResult parseResult)
+        internal static InvalidTemplateOptionResult FromParseError(TemplateOption option, ParseResult parseResult, ParseError error)


perf: we don't need to search for the error if the caller can provide it

adamsitnik · 2023-01-20T12:19:16Z

src/Cli/Microsoft.TemplateEngine.Cli/Commands/list/LegacyListCommand.cs

@@ -41,7 +41,8 @@ protected override Task<NewCommandStatus> ExecuteAsync(ListCommandArgs args, IEn

        private void ValidateParentCommandArguments(CommandResult commandResult)
        {
-            var nameArgumentResult = commandResult.Children.FirstOrDefault(symbol => symbol.Symbol == ListCommand.NameArgument);
+            var nameArgumentResult = commandResult.Children.FirstOrDefault(


SymbolResult.Symbol was removed, only ArgumentResult provides ArgumentResult.Argument

adamsitnik · 2023-01-20T12:23:22Z

src/Cli/dotnet/ParseResultExtensions.cs

@@ -212,7 +212,7 @@ private static IEnumerable<string> GetRunPropertyOptions(ParseResult parseResult
            var optionString = shorthand ? "-p" : "--property";
            var options = parseResult.CommandResult.Children.Where(c => c.Token().Type.Equals(TokenType.Option));
            var propertyOptions = options.Where(o => o.Token().Value.Equals(optionString));
-            var propertyValues = propertyOptions.SelectMany(o => o.Children.SelectMany(c => c.Tokens.Select(t=> t.Value))).ToArray();
+            var propertyValues = propertyOptions.SelectMany(o => o.Tokens.Select(t=> t.Value)).ToArray();


OptionResult.Tokens returns Tokens of all its children:

https://github.com/dotnet/command-line-api/blob/01aee747e4524464bfe63b73f59bc68f9abbb33e/src/System.CommandLine/Parsing/ParseResultVisitor.cs#L195-L196

adamsitnik · 2023-01-20T12:23:45Z

src/Cli/dotnet/ParseResultExtensions.cs

@@ -146,7 +146,7 @@ private static string GetSymbolResultValue(ParseResult parseResult, SymbolResult
            }
            else if (symbolResult.Token().Type.Equals(TokenType.Command))
            {
-                return symbolResult.Symbol.Name;
+                return ((System.CommandLine.Parsing.CommandResult)symbolResult).Command.Name;


it must be true based on the condition above

adamsitnik · 2023-01-20T12:24:15Z

src/Cli/dotnet/Telemetry/AllowListToSendFirstAppliedOptions.cs

@@ -26,8 +26,8 @@ public List<ApplicationInsightsEntryFormat> AllowList(ParseResult parseResult, D
            if (_topLevelCommandNameAllowList.Contains(topLevelCommandNameFromParse))
            {
                var firstOption = parseResult.RootCommandResult.Children
-                    .FirstOrDefault(c => c.Token() != default && c.Token().Type.Equals(TokenType.Command))?
-                    .Children.FirstOrDefault(c => c is System.CommandLine.Parsing.CommandResult)?.Symbol.Name ?? null;
+                    .OfType<System.CommandLine.Parsing.CommandResult>().FirstOrDefault()?


only CommandResult defines Children property now

adamsitnik · 2023-01-20T12:25:26Z

src/Cli/dotnet/commands/dotnet-complete/Complete.cs

-
-        public static Func<CompletionContext, IEnumerable<CompletionItem>> TargetFrameworksFromProjectFile =>
-            (_context) =>
+        public static IEnumerable<CompletionItem> TargetFrameworksFromProjectFile(CompletionContext _)


these properties was allocating memory each time they were called. We can just define static methods rather than properties that return lambdas.

adamsitnik · 2023-01-20T12:27:48Z

src/Cli/dotnet/commands/dotnet-test/TestCommandParser.cs

+                ArgumentHelpName = LocalizableStrings.CrashDumpTypeArgumentName,
+            }
+            .ForwardAsMany(o => new[] { "-property:VSTestBlameCrash=true", $"-property:VSTestBlameCrashDumpType={o}" });
+            result.AcceptOnlyFromAmong(new string[] { "full", "mini" });


this method is no longer an extension method that returns the option (BCL requirement is that only builder types are allowed to do this)

adamsitnik · 2023-01-20T16:00:23Z

Have these breaking changes flowed into any other repos yet?

No, this is the only repo that still has System.CommandLine auto-updates enabled.

Anyway I am going to work on updating all of them, as it's a good source of feedback for me (so far I've discovered one bug).

MichaelSimons · 2023-01-20T16:03:14Z

No, this is the only repo that still has System.CommandLine auto-updates enabled.

If we merge this without updating the others it will break source-build. We should coordinate merging this PR with updating the other repos.

…uild 20230606.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.356401 -> To Version 0.1.430601

adamsitnik

Summary of the most important code changes:

many types have been renamed and they have Cli prefix now. This should allow us to avoid naming conflicts.
the symbol types no longer expose .AddXYZ methods, they expose XYZ collections (typically lists), so we can perform Add, Clear, RemoveAt and similar operations
Command.AddGlobalOption is gone, the CliOption type is now exposing Recursive property (previously there was an internal Global property that the removed method was setting)
InvocationContext is gone, as ParseResult is all we need for invocation. CancellationToken is now being passed to all async actions, if we don't propagate it, we get a compiler warning.
SymbolResult exposes AddError which allows us to report more than one error (previously it was a mutable ErrorMessage property which was limiting us to only one parse error per symbol)
IConsole was removed, the config is now exposing Output and Error which are both just TextWriters
the non-generic overload for setting default value was removed, as it was allowing for introducing silent bugs. Example: defining an CliOption<int> and passing bool as default value.
ICommandHandler has been replaced with CliAction
LocalizationResources are gone, the resources from SDK were merged into S.CL resources (see Localization command-line-api#2041 for details).
Middleware is gone, it was expensive, complex and almost not used at all.
the CliOption ctor accepts (string name, params string[] aliases). It required to update plenty of usages, but gives us a clear separation betweeen Name and Aliases. Previously Name was the longest alias without prefix. Now it needs to be provided in explicit way and it's not included in the Alises collection.

This introduces the only breaking change:

So far, for every option the help was printing name, aliases and name without prefix or help name when it was provided. Now we don't print name without prefix right:

- --name, --alias1, -a <name> description
+ --name, --alias1, -a  description

Sample diff:

I've reviewed all my changes and added comments in places where they might not seem obvious.

@baronfel PTAL, the PR is ready for review now.

src/BlazorWasmSdk/Tool/Program.cs

adamsitnik · 2023-06-06T18:49:25Z

src/Cli/Microsoft.TemplateEngine.Cli/CliTemplateParameter.cs

@@ -149,7 +150,34 @@ internal Option GetOption(IReadOnlySet<string> aliases)
                if (!string.IsNullOrWhiteSpace(DefaultValue)
                    || (Type == ParameterType.String || Type == ParameterType.Choice) && DefaultValue != null)
                {
-                    option.SetDefaultValue(DefaultValue);
+                    switch (option)


the non-generic overload for setting default value was removed, as it was allowing for introducing silent bugs. Example: defining an CliOption<int> and passing bool as default value.

I know that this switch is far from perfect, I am open to suggestions about how it can be improved.

this is probably ok for the template engine - it has a relatively constrained set of types that are allowable as part of the grammar for template options (choice, string, bool, int, etc), and this just becomes an explicit mapping that needs to occur.

@dotnet/templating-engine-maintainers can you take a look and verify that all of our data types are manually mapped here now?

adamsitnik · 2023-06-06T19:03:48Z

src/Cli/Microsoft.TemplateEngine.Cli/Commands/create/InstantiateCommand.Help.cs


 namespace Microsoft.TemplateEngine.Cli.Commands
 {
    internal partial class InstantiateCommand
    {
        private const string Indent = "  ";
+        private static Lazy<ResourceManager> _resourceManager = new Lazy<ResourceManager>(


LocalizationResources are no longer public, the resources from SDK were merged into S.CL resources (see dotnet/command-line-api#2041 for details). To read the 4 resources that were actually used by SDK I've decided to use ResourceManager to read S.CL resources. In the long term, we should remove it.

adamsitnik · 2023-06-06T19:14:39Z

src/Cli/dotnet/Parser.cs


        // Argument
-        public static readonly Argument<string> DotnetSubCommand = new Argument<string>() { Arity = ArgumentArity.ExactlyOne, IsHidden = true };
+        public static readonly CliArgument<string> DotnetSubCommand = new("subcommand") { Arity = ArgumentArity.ZeroOrOne, Hidden = true };


Previously this argument was marked as ArgumentArity.ExactlyOne which was making it a required argument. When it was not provided, a parse error was being reported. Since it's not required, I've changed it to optional (ArgumentArity.ExactlyOne), so fewer workarounds are required elsewhere (like not ignoring certain parse errors)

adamsitnik · 2023-06-06T19:15:39Z

src/Cli/dotnet/Parser.cs


-            return rootCommand;
-        }
+            rootCommand.SetAction(parseResult =>


so far the root command had no explicit handler, but in reality it had some defined in Program.cs. I've moved this logic here and used the built-in mechanism for that.

src/Cli/dotnet/Telemetry/TopLevelCommandNameAndOptionToLog.cs

src/Cli/dotnet/commands/dotnet-vstest/VSTestCommandParser.cs

It was my own review that I've used to prevent someone from merging it by accident

tmat · 2023-06-06T21:20:13Z

src/BuiltInTools/dotnet-watch/CommandLineOptions.cs

    {
-        var quietOption = new Option<bool>(new[] { "--quiet", "-q" }, "Suppresses all output except warnings and errors");
-        var verboseOption = new Option<bool>(new[] { "--verbose", "-v" }, "Show verbose output");
+        CliOption<bool> quietOption = new("--quiet", "-q")


Can you please keep the previous style, i.e. var _ = new CliOption<bool>(...) instead of CliOption<bool> _ = new(...)? It'd be a) easier to read the PR and b) consistent with https://github.com/dotnet/sdk/pull/29131/files#diff-48c696e38dedfa782c9bb14f1e5749d861c4cd6ae825edda9497bb62deebdc3cR146

@tmat I apology, I should not bring my var obsession from dotnet/runtime to this repo.

Changing that is possible, but it would take me quite a lot of time (I could automate it only partially) for the entire solution. Unless you are concerned about only this particular file?

Just this particular file.

@tmat done, PTAL

src/Cli/dotnet/Parser.cs

baronfel · 2023-06-06T22:06:52Z

...ngine.Cli.UnitTests/ParserTests/Approvals/HelpTests.CanShowCommandOptions_Basic.verified.txt

-  -n, --name <name>      The name for the output being created. If no name is specified, the name of the output directory is used.
-  -o, --output <output>  Location to place the generated output.
-  --dry-run              Displays a summary of what would happen if the given command line were run if it would result in a template creation.
-  --force                Forces content to be generated even if it would change existing files.
-  --no-update-check      Disables checking for the template package updates when instantiating a template.
-  --project <project>    The project that should be used for context evaluation.


for these kinds of diffs, we should supply and HelpName if we want to keep this layout, correct @adamsitnik?

for these kinds of diffs, we should supply and HelpName if we want to keep this layout, correct

That is correct. Would you like me to add the HelpName values and keep the old layout?

baronfel · 2023-06-06T22:07:50Z

src/Tests/Microsoft.TemplateEngine.Cli.UnitTests/ParserTests/InstantiateTests.cs

@@ -504,7 +503,7 @@ internal void CanParseMultiChoiceTemplateOptions(string command, string paramete
                //new object?[] { "foo --framework", "framework", "net5.0|net6.0", false, null, null, "Required argument missing for option: '--framework'." },
                //requireness is no longer set on parser level
                //new object?[] { "foo", "framework", "net5.0|net6.0", true, null, null, "Option '--framework' is required." },
-                new object?[] { "foo --framework", "framework", "net5.0|net6.0", true, null, "netcoreapp2.1", $"Cannot parse default if option without value 'netcoreapp2.1' for option '--framework' as expected type 'choice': value 'netcoreapp2.1' is not allowed, allowed values are: 'net5.0','net6.0'. Did you mean one of the following?{Environment.NewLine}net5.0{Environment.NewLine}net6.0" }


Did levenstein get removed from suggestions?

In this particular case, the error message got simplified.

Before the changes the first sentence was finished with:

allowed values are: 'net5.0','net6.0'

Then in the next one the information was repeated (in a way, the meaning was the same):

Did you mean one of the following?{Environment.NewLine}net5.0{Environment.NewLine}net6.0

adamsitnik · 2023-06-07T16:24:44Z

I forgot to mention that the S.CL update brings some perf improvements.

In case of things like --info or --version that include only the parsing, gains are around few ms.

For other things that include calling ParseResult.Invoke the gain can be even up to 70 ms in case of things like build --help.

But such huge gains should not be expected for all scenarios, for example for list $projectPath reference I observed only 10ms gain.

Method	Args	Mean	Ratio
Main	--version	169.3 ms	1.00
PR	--version	163.8 ms	0.97

Main	build --help	261.3 ms	1.00
PR	build --help	189.9 ms	0.73

Main	list reference	242.9 ms	1.00
PR	list reference	232.0 ms	0.96

…ae-4e82-ad57-55ddf2973d18 # Conflicts: # src/ApiCompat/Microsoft.DotNet.ApiCompat.Tool/Program.cs

…ae-4e82-ad57-55ddf2973d18 # Conflicts: # src/Containers/containerize/ContainerizeCommand.cs # src/Tests/containerize.UnitTests/ParserTests.cs

baronfel

Help changes look good to me, that really reduced the diffs. Thanks @adamsitnik!

…uild 20230607.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.356401 -> To Version 0.1.430701

* nuget command forwards some subcommands to nuget app, so it needs to define TreatUnmatchedTokensAsErrors=false * revert the test change to match old help look

MichaelSimons · 2023-06-08T13:18:44Z

Friendly reminder that this checkin is likely going to block the flow into installer until all of repos that depend on commond-line-api will build with this new version.

…et#29131)" This reverts commit f8831a6. We're reverting this because it blocks installer codeflow. We need to sychronize the changes with other repos that codeflow S.CL so that flow is blocked as little as possible.

baronfel · 2023-06-09T15:35:59Z

@MichaelSimons I've opened a revert PR so we can do that coordination before trying again. After checking darc we'll need to synchronize:

dotnet/format
dotnet/roslyn
dotnet/runtime
dotnet/sdk
dotnet/templating

…)" (#33146)

…pi (#29131)""

adamsitnik · 2023-06-12T11:57:04Z

After checking darc we'll need to synchronize:

@baronfel in what order?

marcpopMSFT · 2023-06-12T18:49:51Z

After checking darc we'll need to synchronize:

@baronfel in what order?

@adamsitnik source build uses a single version so I think that all five need to be coordinated and go in roughly the same time. They'll be fine as the flow until they get to the installer repo so codeflow to installer will be blocked until all five have flowed.

…pi (#29131)"" (#33157)

Update dependencies from https://github.com/dotnet/command-line-api b…

5a564e2

…uild 20221114.2 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.356401 -> To Version 0.1.356402

dotnet-issue-labeler bot added the Area-CodeFlow label Nov 18, 2022

Update dependencies from https://github.com/dotnet/command-line-api b…

33ae728

…uild 20221118.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.356401 -> To Version 0.1.356801

jkotas mentioned this pull request Nov 19, 2022

update System.CommandLine and adopt to breaking changes dotnet/runtime#78577

Merged

adamsitnik added the DO NOT MERGE label Nov 21, 2022

adamsitnik self-assigned this Nov 21, 2022

adamsitnik previously requested changes Nov 21, 2022

View reviewed changes

Update dependencies from https://github.com/dotnet/command-line-api b…

5981597

…uild 20221213.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.356401 -> To Version 0.1.361301

dotnet-maestro bot and others added 5 commits January 19, 2023 23:11

Update dependencies from https://github.com/dotnet/command-line-api b…

68dda8a

…uild 20230119.2 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.356401 -> To Version 0.1.406902

adopt to recent breaking changes: renames, removal of extension methods

fa49eae

adopt to recent breaking changes: removal of Children property

bb036dd

* OptionResult.Tokens returns Tokens of all its children * only CommandResult defines Children property * don't search for ParseError more than once

reduce lambda allocations

76d51bb

adopt to recent breaking changes: SetDefaultValue is now avilable onl…

c12b639

…y for Option<T>, to avoid type mismatches (example: Option<int> using default value as "abc")

adamsitnik requested review from a team as code owners January 20, 2023 11:39

adamsitnik reviewed Jan 20, 2023

View reviewed changes

adamsitnik mentioned this pull request Jan 20, 2023

UnrecognizedArgument error should mention first invalid argument, not the last one dotnet/command-line-api#2029

Merged

address one of the discovered problems

4c8a5f4

Update dependencies from https://github.com/dotnet/command-line-api b…

2c6f23b

…uild 20230606.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.356401 -> To Version 0.1.430601

adamsitnik reviewed Jun 6, 2023

View reviewed changes

adamsitnik removed the DO NOT MERGE label Jun 6, 2023

tmat reviewed Jun 6, 2023

View reviewed changes

baronfel reviewed Jun 6, 2023

View reviewed changes

src/Cli/dotnet/Parser.cs Show resolved Hide resolved

baronfel reviewed Jun 6, 2023

View reviewed changes

adamsitnik added 4 commits June 7, 2023 18:52

Merge remote-tracking branch 'origin/main' into darc-main-d950046d-c6…

4daa474

…ae-4e82-ad57-55ddf2973d18 # Conflicts: # src/ApiCompat/Microsoft.DotNet.ApiCompat.Tool/Program.cs

address code review feedback: restore var to get smaller diff

b21ccca

address code review feedback: use HelpName to avoid help output changes

6bc18d3

Merge remote-tracking branch 'origin/main' into darc-main-d950046d-c6…

ceb0610

…ae-4e82-ad57-55ddf2973d18 # Conflicts: # src/Containers/containerize/ContainerizeCommand.cs # src/Tests/containerize.UnitTests/ParserTests.cs

baronfel approved these changes Jun 7, 2023

View reviewed changes

Update dependencies from https://github.com/dotnet/command-line-api b…

d1d3d4e

…uild 20230607.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.356401 -> To Version 0.1.430701

adamsitnik mentioned this pull request Jun 8, 2023

Update System.CommandLine version dotnet/runtime#84229

Merged

test fixes:

c5b54eb

* nuget command forwards some subcommands to nuget app, so it needs to define TreatUnmatchedTokensAsErrors=false * revert the test change to match old help look

dotnet-maestro bot merged commit f8831a6 into main Jun 8, 2023
19 checks passed

dotnet-maestro bot deleted the darc-main-d950046d-c6ae-4e82-ad57-55ddf2973d18 branch June 8, 2023 12:38

MichaelSimons mentioned this pull request Jun 8, 2023

[main] Update dependencies from dotnet/sdk dotnet/installer#16621

Merged

oleksandr-didyk mentioned this pull request Jun 9, 2023

enable repo pvp for msbuild dotnet/installer#16637

Merged

marcpopMSFT added a commit that referenced this pull request Jun 9, 2023

Revert "[main] Update dependencies from dotnet/command-line-api (#29131…

3eec09e

…)" (#33146)

marcpopMSFT added a commit that referenced this pull request Jun 9, 2023

Revert "Revert "[main] Update dependencies from dotnet/command-line-a…

7962096

…pi (#29131)""

adamsitnik pushed a commit that referenced this pull request Jun 30, 2023

Revert "Revert "[main] Update dependencies from dotnet/command-line-a…

6483a69

…pi (#29131)"" (#33157)

MiYanni mentioned this pull request Jan 12, 2024

Re-enable env var directives in the .NET CLI #37827

Merged

[main] Update dependencies from dotnet/command-line-api #29131

[main] Update dependencies from dotnet/command-line-api #29131

Conversation

dotnet-maestro bot commented Nov 18, 2022 • edited Loading

From https://github.com/dotnet/command-line-api

marek-safar commented Nov 21, 2022

adamsitnik left a comment

Choose a reason for hiding this comment

marcpopMSFT commented Dec 6, 2022

ViktorHofer commented Jan 17, 2023

adamsitnik commented Jan 18, 2023

jeffhandley commented Jan 19, 2023

ViktorHofer commented Jan 19, 2023

MichaelSimons commented Jan 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamsitnik commented Jan 20, 2023

MichaelSimons commented Jan 20, 2023

adamsitnik left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamsitnik commented Jun 7, 2023

baronfel left a comment

Choose a reason for hiding this comment

MichaelSimons commented Jun 8, 2023

baronfel commented Jun 9, 2023 • edited Loading

adamsitnik commented Jun 12, 2023

marcpopMSFT commented Jun 12, 2023

dotnet-maestro bot commented Nov 18, 2022 •

edited

Loading

adamsitnik left a comment •

edited

Loading

baronfel commented Jun 9, 2023 •

edited

Loading