Crossgen Task

[fadimounir]

Intitial implementation of the crossgen task, and plumbing in the SDK targets to invoke the task. The crossgen task invokes crossgen from the runtime pack.

• Task triggered when is set to true in the main app's project file (opt-in feature)
• Added new condition to download runtime packs: when the ReadyToRun property is set.
• Adding R2R exclusion list capability
• Symbol emission is optional (opt-in, when ReadyToRunEmitSymbols is set to true)

[fadimounir]

@nguerrera Here's the crossgen task. It's still WIP since I haven't tested on OSX yet (tested on Linux and Windows).

[fadimounir]

Tested on OSX

[nguerrera]

I am not finished reviewing everything, but didn't want to hold back these comments.

[fadimounir]

@nguerrera Doesn't look like I have access to merge this. Could you please take another look at the new changes I posted, and merge if it looks good?

[nguerrera]

Sorry for the delay in doing a full review. I have some more concerns noted above.

Also, tests need to be added.

[fadimounir]

@nguerrera I changed the platform validation logic a bit to consume the runtime graph as we discussed, to validate target/host platform compatibility. It now does so by comparing the best matching RID of the target to the best matching RID of the host. Tested it on Ubuntu, OSX, Alpine, and RHEL.6.

I need some pointers on how to add a test to the CI. I can add it as a separate PR.

[nguerrera]

For the tests, look a GuvenThatWeWantToCrossPublish for simple example.

You probably want to mix this with PackageReferences and ProjectReferences to get more than one file to crossgen and to test more cases. GivenThatWeWantDesignerSupport shows this.

You can enable ReadyToRun via TestProject.AdditionalProperties.

It would be nice to have negative coverage for the mismatched host, and coverage of all the options (PDBs, exclude list).

[nguerrera]

I need some pointers on how to add a test to the CI. I can add it as a separate PR.

We always include tests in the original PR. I've put some pointers above. Feel free to grab some time with me if you want to pair on this or have more questions about it.