Fix generate package on build pack as tool #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(circular dependency come from circular bug, that's so meta) |
added 2 commits
May 21, 2019 22:27
NuGet/Home#7801 since nuget no longer sets NoBuild on GeneratePackageOnBuild we need to do similar logic to get the previous state.
This reverts commit a22c859.
wli3
force-pushed
the
fix-GeneratePackageOnBuild-pack-as-tool
branch
from
988c8cb
to
d59a547
Compare
|
done |
|
ping review @dsplaisted @peterhuene |
peterhuene
approved these changes
May 22, 2019
wli3
pushed a commit
that referenced
this pull request
Jun 5, 2019
* Fix GeneratePackageOnBuild with PackAsTool both on NuGet/Home#7801 since nuget no longer sets NoBuild on GeneratePackageOnBuild we need to do similar logic to get the previous state.
wli3
pushed a commit
that referenced
this pull request
Jun 5, 2019
* Fix GeneratePackageOnBuild with PackAsTool both on NuGet/Home#7801 since nuget no longer sets NoBuild on GeneratePackageOnBuild we need to do similar logic to get the previous state.
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
…0191021.7 (dotnet#3255) - Microsoft.NETCore.App.Runtime.win-x64 - 3.1.0-preview2.19521.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NuGet/Home#7801
(the easiest way to understand that is)since nuget no longer sets NoBuild on GeneratePackageOnBuild, we need to do similar logic to get the previous state.
fix #3253