Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dotnet publish for project with P2P references fails when GeneratePackageOnBuild is true #3365

Closed
pranavkm opened this issue Jun 27, 2019 · 5 comments
Closed

Dotnet publish for project with P2P references fails when GeneratePackageOnBuild is true #3365

pranavkm opened this issue Jun 27, 2019 · 5 comments
Assignees
@wli3
Milestone
Discussion

Comments

@pranavkm
Copy link
Contributor

Based on dotnet/aspnetcore#11636.

#3255 causes publish to fail when a project has project references. Treating NoBuild and GeneratePackageOnBuild as equivalent causes project references to stop building.

Repro steps:
@pranavkm
Copy link
Contributor Author

cc @dsplaisted \ @wli3

@pranavkm pranavkm mentioned this issue Jun 27, 2019
Closed
@livarcocc livarcocc added this to the Discussion milestone Jun 27, 2019
@livarcocc
Copy link
Contributor

@wli3 this looks similar to the other one I just assigned to you.

@wli3
Copy link

wli3 commented Jul 26, 2019

@pranavkm could you try again with the latest SDK. #3255 is fixed.

I am using preview 7. I can no longer repro

image

@wli3
Copy link

wli3 commented Jul 26, 2019

hm... seems like I need to run build first. Or it will fail

@wli3
Copy link

wli3 commented Aug 5, 2019

duplicated. prefer #3367

@wli3 wli3 closed this as completed Aug 5, 2019
dsplaisted pushed a commit to dsplaisted/sdk that referenced this issue Feb 19, 2020
@dotnet-maestro
Update dependencies from https://github.com/dotnet/core-setup build 2…
37d00ca 
…0191029.3 (dotnet#3365)

- Microsoft.NETCore.App.Ref - 3.1.0-preview2.19529.3
- Microsoft.NETCore.App.Runtime.win-x64 - 3.1.0-preview2.19529.3

Dependency coherency updates

- Microsoft.NET.Sdk.WindowsDesktop - 3.1.0-preview2.19529.8 (parent: Microsoft.NETCore.App.Runtime.win-x64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wli3 wli3

Labels
None yet
Projects
None yet
Milestone
Discussion
Development

No branches or pull requests
3 participants
@pranavkm @livarcocc @wli3