Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require AppHost when publishing AOT #38644

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

MichalStrehovsky
Copy link
Member

We only delete it anyway.

Contributes to dotnet/runtime#89763
Contributes to dotnet/runtime#79575

_RuntimeIdentifierUsesAppHost is not a great name for this but I need exactly the same sematic. Renaming the existing property is not an option because there's external dependencies on this.

Cc @dotnet/ilc-contrib @rolfbjarne @ViktorHofer

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-External untriaged Request triage from a team member labels Feb 9, 2024
@ViktorHofer
Copy link
Member

I just saw @jkotas's comment in the other issue:

We do want to keep using app host for dotnet run or F5 in Visual Studio. I do not think we want to change the global default to false when PublishAot is set.

@MichalStrehovsky
Copy link
Member Author

I just saw @jkotas's comment in the other issue:

We do want to keep using app host for dotnet run or F5 in Visual Studio. I do not think we want to change the global default to false when PublishAot is set.

That's what the '$(_IsPublishing)' == 'true' part is guarding.

@ViktorHofer ViktorHofer merged commit f816e36 into main Feb 9, 2024
16 checks passed
@ViktorHofer ViktorHofer deleted the MichalStrehovsky-patch-1 branch February 9, 2024 14:08
@ilonatommy
Copy link
Member

/backport to release/8.0.4xx

Copy link
Contributor

Started backporting to release/8.0.4xx: https://github.com/dotnet/sdk/actions/runs/10177576653

@ilonatommy
Copy link
Member

/backport to release/8.0.1xx

Copy link
Contributor

Started backporting to release/8.0.1xx: https://github.com/dotnet/sdk/actions/runs/10177871330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-External untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants