Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/runtime #40853

Merged
merged 10 commits into from
May 16, 2024
Merged

[main] Update dependencies from dotnet/runtime #40853

merged 10 commits into from
May 16, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 14, 2024 •
edited

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: cedddd63-79f5-4e7e-6d46-08dc434c4948
  • Build: 20240515.2
  • Date Produced: May 15, 2024 5:59:54 PM UTC
  • Commit: 1f08a3621e6b531b31e358b99b4c54ba556a61c0
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport: from 9.0.0-preview.5.24252.4 to 9.0.0-preview.5.24263.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
    • Microsoft.SourceBuild.Intermediate.emsdk: from 9.0.0-preview.5.24252.4 to 9.0.0-preview.5.24263.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
12367f2 
…0513.11

Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24263.11
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels May 14, 2024
@dotnet-maestro DotNet Maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
9b43a0b 
…0513.12

Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24263.12
@v-wuzhai
Copy link
Member

@dotnet/aspnet-blazor-eng Could you take a look at the failures here?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
94182c8 
…0514.1

Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24264.1
@eerhardt
Copy link
Member

Failures say:

image

@eerhardt
Copy link
Member

@kg - could this be related to dotnet/runtime#101460?

@kg
Copy link

kg commented May 14, 2024

@kg - could this be related to dotnet/runtime#101460?

I don't believe so

@eerhardt
Copy link
Member

eerhardt commented May 14, 2024 •
edited

dotnet/runtime@073e35e...bad00cf is the runtime diff for this PR. In case someone else can spot a change that would have broken this test.

The very first commit of this PR appears to have failed for the same reason. The diff of that commit excludes dotnet/runtime#101460. So it must not be that.

Here is the slimmed down diff: dotnet/runtime@073e35e...a37af85

@kg
Copy link

kg commented May 14, 2024

It seems possible the dependency on those two assemblies was just optimized out at some point, perhaps in one of the dependency pulls in that diff range. Those two assemblies going away doesn't necessarily seem to indicate something went wrong, if all our other tests are passing.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
88dd92f 
…0514.4

Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24264.4

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 9.0.0-preview.5.24252.4 -> To Version 9.0.0-preview.5.24263.1 (parent: Microsoft.NETCore.App.Runtime.win-x64
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
21cf10c 
…0514.9

Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24264.9

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 9.0.0-preview.5.24252.4 -> To Version 9.0.0-preview.5.24263.1 (parent: Microsoft.NETCore.App.Runtime.win-x64
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
ed8815f 
…0514.10

Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24264.10

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 9.0.0-preview.5.24252.4 -> To Version 9.0.0-preview.5.24263.1 (parent: Microsoft.NETCore.App.Runtime.win-x64
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
1939a89 
…0515.1

Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24265.1

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 9.0.0-preview.5.24252.4 -> To Version 9.0.0-preview.5.24263.1 (parent: Microsoft.NETCore.App.Runtime.win-x64
@lewing
Copy link
Member

lewing commented May 15, 2024

Aren't those assemblies just facades? I think you can just update the baselines like the error suggests.

@lewing
Copy link
Member

lewing commented May 15, 2024

@javiercn now we are hitting staticwebassets failures

@lewing lewing requested a review from javiercn May 15, 2024 17:13
@lewing
Copy link
Member

lewing commented May 15, 2024

cc @maraf

dotnet-maestro bot and others added 2 commits May 15, 2024 18:23
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
b83e580 
…0515.2

Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24265.2

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 9.0.0-preview.5.24252.4 -> To Version 9.0.0-preview.5.24263.1 (parent: Microsoft.NETCore.App.Runtime.win-x64
@MackinnonBuck
Update baselines
61750c0
@dotnet-maestro dotnet-maestro bot requested review from a team as code owners May 15, 2024 18:42
@build-analysis build-analysis bot mentioned this pull request May 16, 2024
Open
@dotnet-maestro dotnet-maestro bot merged commit 8177801 into main May 16, 2024
28 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-f0f27ab1-3d9c-4a48-a21e-8f0d96065f2d branch May 16, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraf maraf maraf approved these changes

@javiercn javiercn Awaiting requested review from javiercn

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@v-wuzhai @eerhardt @kg @lewing @maraf @MackinnonBuck