Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/arcade #42249

Merged
merged 4 commits into from
Jul 21, 2024
Merged

[main] Update dependencies from dotnet/arcade #42249

merged 4 commits into from
Jul 21, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 19, 2024 •
edited

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 3d9043af-0e17-4eb5-f3e3-08d8e97c775d
  • Build: 20240718.9
  • Date Produced: July 18, 2024 4:59:11 PM UTC
  • Commit: b4e499d1f6e6b3a981feabfed290d99261762382
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
7a734b8 
…718.9

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.24360.4 -> To Version 9.0.0-beta.24368.9
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jul 19, 2024
@nagilson
Copy link
Member

@mmitche @ViktorHofer @garath @akoeplinger It looks like this change has broken a test for a fairly simple reason, may you please correct this change? Do not use Assert.Empty() to check if a value does not exist in a collection. Use Assert.DoesNotContain() instead

@ViktorHofer
Copy link
Member

ViktorHofer commented Jul 19, 2024 •
edited

Arcade's dependency update brings a long a newer of xunit: 2.8.1 -> 2.9.0 which brings a long a new version of xunit.analyzers. Here's the changelog for it: https://xunit.net/releases/analyzers/1.15.0

We have created xUnit2029 to suggest that users can convert code like this

The build failures are due to a new analyzer in xunit. That's general goodness and nothing unusual. The dnceng team (who owns Arcade) isn't responsible for fixing those analyzer warnings. Arcade is just the vehicle that brings in newer versions of xunit (which we decided on doing a while ago). You can disable the warning if disagree with it or downgrade to an older version or xunit / xunit.analyzers (which I wouldn't recommend).

This is similar to any other dependency update PR, i.e. runtime when we obsolete API or add a new analyzer inbox to the shared framework. These types of changes need reaction on the consumption side.

@build-analysis build-analysis bot mentioned this pull request Jul 19, 2024
Open
3 tasks
dotnet-maestro bot and others added 2 commits July 20, 2024 12:16
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
36dbbee 
…718.9

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.24360.4 -> To Version 9.0.0-beta.24368.9
@akoeplinger
Fix xUnit2029 warning
90cbc97
@akoeplinger akoeplinger requested a review from a team as a code owner July 21, 2024 08:09
@build-analysis build-analysis bot mentioned this pull request Jul 21, 2024
Open
3 tasks
@dotnet-maestro dotnet-maestro bot merged commit bec4063 into main Jul 21, 2024
41 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-0cef5441-ca5d-478d-9a91-e73a16dded49 branch July 21, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nagilson @ViktorHofer @akoeplinger