Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change base retry delay to 5 sec #327

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Conversation

aok-foss
Copy link
Contributor

@aok-foss aok-foss commented Dec 4, 2020

All signing methods perform 3 attempts to sign.

The retrying code looks like the intention is to start with a delay of 5 seconds and then increase the delay exponentially: 5s before attempt 2, 11.1s before attempt 3.
Because the increase happens before the first retry, the actual delay times are 11.1s before attempt 2 and 37.3s before attempt 3.

This change makes the actual behaviour match the assumed intention.

@clairernovotny clairernovotny merged commit 551a4d5 into dotnet:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants