Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Microsoft.SourceBuild.Intermediate from prebuilt baseline #1153

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Dec 7, 2023

Prebuilt detection no longer detects Microsoft.SourceBuild.Intermediates as prebuilts due to dotnet/arcade#13935.

Addresses dotnet/source-build#3010

@ellahathaway
Copy link
Member Author

@tmat @MichaelSimons Could you take a look at the changes in this PR when you get a chance, thanks!

@ellahathaway
Copy link
Member Author

I also wanted to follow up on #1038 (comment) - if you are alright with granting write access then I will add the source-build-internals to the CODEOWNERS file.

@tmat
Copy link
Member

tmat commented Dec 13, 2023

Can we delete the file entirely?

@ellahathaway
Copy link
Member Author

Can we delete the file entirely?

After looking at https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.SourceBuild/tasks/src/UsageReport/ValidateUsageAgainstBaseline.cs#L24, it appears that this file can technically be deleted and prebuilt detection would default to comparing against <UsageData />.

That said, IMO the effort involved in reintroducing the file later, should a prebuilt be detected and deemed acceptable, surpasses the advantages of deleting the file now.

@tmat tmat merged commit 20ebd36 into dotnet:main Dec 13, 2023
10 checks passed
@ellahathaway ellahathaway deleted the update-prebuilt-baseline branch December 13, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants