Allow EOLN in quoted config value and report better message when parsing fails #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidwengier PTAL |
davidwengier
approved these changes
Dec 15, 2023
tmat
added a commit
to tmat/sourcelink
that referenced
this pull request
Dec 15, 2023
tmat
added a commit
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://developercommunity.visualstudio.com/t/Error-reading-repository-information-F/10519873
The implementation didn't correctly handle scenario where a quoted value in git configuration file had line breaks.
Customer Impact
Build in repositories with such configuration fails after the customer upgrades their toolset to .NET 8 SDK.
Regression?
7.0
Risk
Verification
Packaging changes reviewed?