Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Expose SequenceReader<T> and friends #1500

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Expose SequenceReader<T> and friends #1500

merged 1 commit into from
Sep 6, 2019

Conversation

terrajobst
Copy link
Member

Fixes #1493, #1497

/cc @chris579

@terrajobst terrajobst added the netstandard-api This tracks requests for standardizing APIs. label Sep 5, 2019
@terrajobst terrajobst added this to the .NET Standard vNext milestone Sep 5, 2019
@terrajobst terrajobst requested review from a team as code owners September 5, 2019 02:57
@terrajobst
Copy link
Member Author

Once this is merged into master, we can submit a request to merge it into release/3.0

@davidfowl
Copy link
Member

Yassss!!!

ahsonkhan
ahsonkhan approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's good.

@terrajobst
Copy link
Member Author

@jaredpar @onovotny

@terrajobst terrajobst force-pushed the readonlysequence branch 2 times, most recently from 9ac2f3b to ed6d9f6 Compare September 6, 2019 00:17
safern
safern suggested changes Sep 6, 2019
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since SequenceReader generic constaint of T has to be unmanaged.

@terrajobst terrajobst mentioned this pull request Sep 6, 2019
Closed
@terrajobst terrajobst merged commit fd6c634 into dotnet:master Sep 6, 2019
@terrajobst terrajobst deleted the readonlysequence branch September 6, 2019 21:34
@safern safern mentioned this pull request Feb 1, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@jkotas jkotas jkotas left review comments

@ericstj ericstj ericstj left review comments

@safern safern safern approved these changes

@davidfowl davidfowl davidfowl approved these changes

@joshpeterson joshpeterson joshpeterson approved these changes

@jaredpar jaredpar jaredpar approved these changes

@marek-safar marek-safar marek-safar approved these changes

@khellang khellang khellang approved these changes

@clairernovotny clairernovotny clairernovotny approved these changes

@ahsonkhan ahsonkhan ahsonkhan approved these changes

Assignees
No one assigned
Labels
netstandard-api This tracks requests for standardizing APIs.
Projects
None yet
Milestone
.NET Standard vNext
Development

Successfully merging this pull request may close these issues.

Make SequenceReader available