This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Fix old project system warnings #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When NETStandard.Library was referenced in a .NETFramework project using the old project system, it would evaluate the project ignoring conditions on ItemGroups. Apparently this is done to display the superset of project configurations (eg both debug and release) in the solution heirarchy. The warnings were a result of the items never being resolved after design time build finished resolving references (because of course the items were conditioned out for the target framework). We can workaround this using choose/when. Apparently the evaluation of the project is bold enough to ignore the conditions on an itemgroup, but not bold enough to choose one of many when (or all) clauses. :)
We were appending an unnecessary slash after MSBuildThisFileDirectory in our targets. This wasn't breaking anything but it should be cleaned up to avoid being a red-herring.
weshaggard
approved these changes
Apr 18, 2018
|
It might be worth pinging someone on the project system side to see if this is a known thing. |
|
@davkean does this sound right? |
|
It's really an MSBuild bug that you are relying on that won't get fixed; old project system says "give us all items ignoring conditions" and it MSBuild doesn't return these. Others are doing the same pattern. |
|
Yeah, it felt more safe to rely on the choose/when behavior than what we previously got. Previously this was working because MSBuild wasn't evaluating the property that was used in the item, so the wildcard item came up empty (so long as folks didn't have any *.dll in the project directory 😖, if a DLL was in the directory it would also have the same behavior described in this issue). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NETStandard.Library was referenced in a .NETFramework project using the old project system,
it would evaluate the project ignoring conditions on ItemGroups. Apparently this is done to
display the superset of project configurations (eg both debug and release) in the solution heirarchy.
The warnings were a result of the items never being resolved after design time build finished
resolving references (because of course the items were conditioned out for the target framework).
We can workaround this using choose/when. Apparently the evaluation of the project is bold
enough to ignore the conditions on an itemgroup, but not bold enough to choose one of many
when (or all) clauses. :)
Fixes #708